* [PATCH] Fix inc_rt_tasks() to not declare variable 'rq' if it's not needed
@ 2008-07-11 12:34 David Howells
2008-07-11 13:04 ` [PATCH] Fix inc_rt_tasks() to not declare variable 'rq' if it's notneeded Gregory Haskins
2008-07-18 11:56 ` [PATCH] Fix inc_rt_tasks() to not declare variable 'rq' if it's not needed Ingo Molnar
0 siblings, 2 replies; 3+ messages in thread
From: David Howells @ 2008-07-11 12:34 UTC (permalink / raw)
To: mingo, ghaskins, akpm; +Cc: dhowells, tglx, linux-kernel
Fix inc_rt_tasks() to not declare variable 'rq' if it's not needed. It is
declared if CONFIG_SMP or CONFIG_RT_GROUP_SCHED, but only used if CONFIG_SMP.
This is a consequence of patch 1f11eb6a8bc92536d9e93ead48fa3ffbd1478571 plus
patch 1100ac91b6af02d8639d518fad5b434b1bf44ed6.
Signed-off-by: David Howells <dhowells@redhat.com>
---
kernel/sched_rt.c | 2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/kernel/sched_rt.c b/kernel/sched_rt.c
index acba8eb..ec19ce5 100644
--- a/kernel/sched_rt.c
+++ b/kernel/sched_rt.c
@@ -505,7 +505,9 @@ void inc_rt_tasks(struct sched_rt_entity *rt_se, struct rt_rq *rt_rq)
rt_rq->rt_nr_running++;
#if defined CONFIG_SMP || defined CONFIG_RT_GROUP_SCHED
if (rt_se_prio(rt_se) < rt_rq->highest_prio) {
+#ifdef CONFIG_SMP
struct rq *rq = rq_of_rt_rq(rt_rq);
+#endif
rt_rq->highest_prio = rt_se_prio(rt_se);
#ifdef CONFIG_SMP
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] Fix inc_rt_tasks() to not declare variable 'rq' if it's notneeded
2008-07-11 12:34 [PATCH] Fix inc_rt_tasks() to not declare variable 'rq' if it's not needed David Howells
@ 2008-07-11 13:04 ` Gregory Haskins
2008-07-18 11:56 ` [PATCH] Fix inc_rt_tasks() to not declare variable 'rq' if it's not needed Ingo Molnar
1 sibling, 0 replies; 3+ messages in thread
From: Gregory Haskins @ 2008-07-11 13:04 UTC (permalink / raw)
To: mingo, akpm, David Howells; +Cc: tglx, linux-kernel
>>> On Fri, Jul 11, 2008 at 8:34 AM, in message
<20080711123454.10475.33099.stgit@warthog.procyon.org.uk>, David Howells
<dhowells@redhat.com> wrote:
> Fix inc_rt_tasks() to not declare variable 'rq' if it's not needed. It is
> declared if CONFIG_SMP or CONFIG_RT_GROUP_SCHED, but only used if
> CONFIG_SMP.
>
> This is a consequence of patch 1f11eb6a8bc92536d9e93ead48fa3ffbd1478571 plus
> patch 1100ac91b6af02d8639d518fad5b434b1bf44ed6.
>
> Signed-off-by: David Howells <dhowells@redhat.com>
Acked by: Gregory Haskins <ghaskins@novell.com>
> ---
>
> kernel/sched_rt.c | 2 ++
> 1 files changed, 2 insertions(+), 0 deletions(-)
>
>
> diff --git a/kernel/sched_rt.c b/kernel/sched_rt.c
> index acba8eb..ec19ce5 100644
> --- a/kernel/sched_rt.c
> +++ b/kernel/sched_rt.c
> @@ -505,7 +505,9 @@ void inc_rt_tasks(struct sched_rt_entity *rt_se, struct
> rt_rq *rt_rq)
> rt_rq->rt_nr_running++;
> #if defined CONFIG_SMP || defined CONFIG_RT_GROUP_SCHED
> if (rt_se_prio(rt_se) < rt_rq->highest_prio) {
> +#ifdef CONFIG_SMP
> struct rq *rq = rq_of_rt_rq(rt_rq);
> +#endif
>
> rt_rq->highest_prio = rt_se_prio(rt_se);
> #ifdef CONFIG_SMP
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] Fix inc_rt_tasks() to not declare variable 'rq' if it's not needed
2008-07-11 12:34 [PATCH] Fix inc_rt_tasks() to not declare variable 'rq' if it's not needed David Howells
2008-07-11 13:04 ` [PATCH] Fix inc_rt_tasks() to not declare variable 'rq' if it's notneeded Gregory Haskins
@ 2008-07-18 11:56 ` Ingo Molnar
1 sibling, 0 replies; 3+ messages in thread
From: Ingo Molnar @ 2008-07-18 11:56 UTC (permalink / raw)
To: David Howells; +Cc: ghaskins, akpm, tglx, linux-kernel
* David Howells <dhowells@redhat.com> wrote:
> Fix inc_rt_tasks() to not declare variable 'rq' if it's not needed. It is
> declared if CONFIG_SMP or CONFIG_RT_GROUP_SCHED, but only used if CONFIG_SMP.
>
> This is a consequence of patch
> 1f11eb6a8bc92536d9e93ead48fa3ffbd1478571 plus patch
> 1100ac91b6af02d8639d518fad5b434b1bf44ed6.
applied, thanks David.
Ingo
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2008-07-18 11:56 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-07-11 12:34 [PATCH] Fix inc_rt_tasks() to not declare variable 'rq' if it's not needed David Howells
2008-07-11 13:04 ` [PATCH] Fix inc_rt_tasks() to not declare variable 'rq' if it's notneeded Gregory Haskins
2008-07-18 11:56 ` [PATCH] Fix inc_rt_tasks() to not declare variable 'rq' if it's not needed Ingo Molnar
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.