All of lore.kernel.org
 help / color / mirror / Atom feed
* RFC: space between -isystem and parameter
@ 2008-07-11 21:21 Robert Schuster
  0 siblings, 0 replies; only message in thread
From: Robert Schuster @ 2008-07-11 21:21 UTC (permalink / raw)
  To: openembedded-devel


[-- Attachment #1.1: Type: text/plain, Size: 397 bytes --]

Hi,
the gcc man page says that there should be a space between the -isystem
option and the parameter. Is there a specific reason why we are not
doing this in OpenEmbedded?

If it is not causing any problems I would like to change this (see
patch, is there more to change?) since I people pointed this out when I
posted a OE-made make output to the libtool mailing list.

Regards
Robert

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1.2: isystem_space.diff --]
[-- Type: text/x-patch; name="isystem_space.diff", Size: 964 bytes --]

#
# old_revision [c3c2fc52f60e174bdf9d1f52c795dc0bdcfb0958]
#
# patch "conf/bitbake.conf"
#  from [d8122151bbc194ee830cb666879ae90585f1b985]
#    to [e113fc3577094afd81f647bfe6068c6dc26b38c9]
#
============================================================
--- conf/bitbake.conf	d8122151bbc194ee830cb666879ae90585f1b985
+++ conf/bitbake.conf	e113fc3577094afd81f647bfe6068c6dc26b38c9
@@ -355,9 +355,9 @@ PATCHRESOLVE = 'noop'
 # Build flags and options.
 ##################################################################
 
-export BUILD_CPPFLAGS = "-isystem${STAGING_INCDIR_NATIVE}"
+export BUILD_CPPFLAGS = "-isystem ${STAGING_INCDIR_NATIVE}"
 export CPPFLAGS = "${TARGET_CPPFLAGS}"
-export TARGET_CPPFLAGS = "-isystem${STAGING_DIR_TARGET}${layout_includedir}"
+export TARGET_CPPFLAGS = "-isystem ${STAGING_DIR_TARGET}${layout_includedir}"
 
 export BUILD_CFLAGS = "${BUILD_CPPFLAGS} ${BUILD_OPTIMIZATION}"
 export CFLAGS = "${TARGET_CFLAGS}"

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 260 bytes --]

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2008-07-11 21:21 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-07-11 21:21 RFC: space between -isystem and parameter Robert Schuster

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.