From: Avi Kivity <avi@qumranet.com>
To: kvm-ia64@vger.kernel.org
Subject: Re: [PATCH 01/04]Create x86 directory to hold x86-specific files.
Date: Sun, 13 Jul 2008 08:53:37 +0000 [thread overview]
Message-ID: <4879C291.9050602@qumranet.com> (raw)
In-Reply-To: <42DFA526FC41B1429CE7279EF83C6BDC015F99FF@pdsmsx415.ccr.corp.intel.com>
Zhang, Xiantao wrote:
> From 03ac444d1ab4446c587e8180ceaba60b9e75b28d Mon Sep 17 00:00:00 2001
> From: Xiantao Zhang <xiantao.zhang@intel.com>
> Date: Fri, 11 Jul 2008 10:13:08 +0800
> Subject: [PATCH] KVM: external module: Moving x86-speicif files to x86
> directory.
>
> Create x86 directory to hold x86-specific files.
> Signed-off-by: Xiantao Zhang <xiantao.zhang@intel.com>
> ---
> kernel/{ => x86}/anon_inodes.c | 0
>
This isn't really x86 specific. It's just kernel version dependent.
The problem is that it is built unconditionally, even if the kernel has
anon_inodes support.
Please send a patch that wraps the entire file in #ifdef so that we use
the host kernel's anon_inodes if it is available.
> kernel/{ => x86}/external-module-compat.c | 0
> kernel/{ => x86}/external-module-compat.h | 0
>
Parts of this are generic, for example the mutex code. Please move only
the x86 specifc parts (even if ia64 doesn't need everything in the
generic code).
--
error compiling committee.c: too many arguments to function
WARNING: multiple messages have this Message-ID (diff)
From: Avi Kivity <avi@qumranet.com>
To: "Zhang, Xiantao" <xiantao.zhang@intel.com>
Cc: kvm-ia64@vger.kernel.org, kvm@vger.kernel.org
Subject: Re: [PATCH 01/04]Create x86 directory to hold x86-specific files.
Date: Sun, 13 Jul 2008 11:53:37 +0300 [thread overview]
Message-ID: <4879C291.9050602@qumranet.com> (raw)
In-Reply-To: <42DFA526FC41B1429CE7279EF83C6BDC015F99FF@pdsmsx415.ccr.corp.intel.com>
Zhang, Xiantao wrote:
> From 03ac444d1ab4446c587e8180ceaba60b9e75b28d Mon Sep 17 00:00:00 2001
> From: Xiantao Zhang <xiantao.zhang@intel.com>
> Date: Fri, 11 Jul 2008 10:13:08 +0800
> Subject: [PATCH] KVM: external module: Moving x86-speicif files to x86
> directory.
>
> Create x86 directory to hold x86-specific files.
> Signed-off-by: Xiantao Zhang <xiantao.zhang@intel.com>
> ---
> kernel/{ => x86}/anon_inodes.c | 0
>
This isn't really x86 specific. It's just kernel version dependent.
The problem is that it is built unconditionally, even if the kernel has
anon_inodes support.
Please send a patch that wraps the entire file in #ifdef so that we use
the host kernel's anon_inodes if it is available.
> kernel/{ => x86}/external-module-compat.c | 0
> kernel/{ => x86}/external-module-compat.h | 0
>
Parts of this are generic, for example the mutex code. Please move only
the x86 specifc parts (even if ia64 doesn't need everything in the
generic code).
--
error compiling committee.c: too many arguments to function
next prev parent reply other threads:[~2008-07-13 8:53 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-11 5:43 [PATCH 01/04]Create x86 directory to hold x86-specific files Zhang, Xiantao
2008-07-11 5:43 ` Zhang, Xiantao
2008-07-13 8:53 ` Avi Kivity [this message]
2008-07-13 8:53 ` Avi Kivity
2008-07-16 9:11 ` Zhang, Xiantao
2008-07-16 9:11 ` Zhang, Xiantao
2008-07-25 9:26 ` Zhang, Xiantao
2008-07-25 9:26 ` Zhang, Xiantao
2008-07-27 7:45 ` Avi Kivity
2008-07-27 7:45 ` Avi Kivity
2008-07-27 9:46 ` Zhang, Xiantao
2008-07-27 9:46 ` Zhang, Xiantao
2008-07-29 13:14 ` Avi Kivity
2008-07-29 13:14 ` Avi Kivity
2008-07-30 1:42 ` Zhang, Xiantao
2008-07-30 1:42 ` Zhang, Xiantao
2008-07-30 14:04 ` Avi Kivity
2008-07-30 14:04 ` Avi Kivity
2008-07-31 3:25 ` Yang, Sheng
2008-07-31 3:25 ` Yang, Sheng
2008-07-31 3:53 ` Zhang, Xiantao
2008-07-31 3:53 ` Zhang, Xiantao
2008-08-01 2:48 ` Zhang, Xiantao
2008-08-01 2:48 ` Zhang, Xiantao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4879C291.9050602@qumranet.com \
--to=avi@qumranet.com \
--cc=kvm-ia64@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.