* [PATCH] ALSA Au1xpsc: psc not disabled when TX is idle
@ 2008-07-15 12:44 Roel Kluin
2008-07-15 13:04 ` Manuel Lauss
0 siblings, 1 reply; 3+ messages in thread
From: Roel Kluin @ 2008-07-15 12:44 UTC (permalink / raw)
To: mano; +Cc: lkml
Untested patch
---
TX idleness isn't tested, but RX twice. PSC is not disabled when TX is idle
Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
---
diff --git a/sound/soc/au1x/psc-i2s.c b/sound/soc/au1x/psc-i2s.c
index ba4b5c1..9384702 100644
--- a/sound/soc/au1x/psc-i2s.c
+++ b/sound/soc/au1x/psc-i2s.c
@@ -231,7 +231,7 @@ static int au1xpsc_i2s_stop(struct au1xpsc_audio_data *pscdata, int stype)
/* if both TX and RX are idle, disable PSC */
stat = au_readl(I2S_STAT(pscdata));
- if (!(stat & (PSC_I2SSTAT_RB | PSC_I2SSTAT_RB))) {
+ if (!(stat & (PSC_I2SSTAT_TB | PSC_I2SSTAT_RB))) {
au_writel(0, I2S_CFG(pscdata));
au_sync();
au_writel(PSC_CTRL_SUSPEND, PSC_CTRL(pscdata));
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] ALSA Au1xpsc: psc not disabled when TX is idle
2008-07-15 12:44 [PATCH] ALSA Au1xpsc: psc not disabled when TX is idle Roel Kluin
@ 2008-07-15 13:04 ` Manuel Lauss
2008-07-15 13:09 ` Takashi Iwai
0 siblings, 1 reply; 3+ messages in thread
From: Manuel Lauss @ 2008-07-15 13:04 UTC (permalink / raw)
To: Roel Kluin; +Cc: lkml
On Tue, Jul 15, 2008 at 02:44:24PM +0200, Roel Kluin wrote:
> Untested patch
> ---
> TX idleness isn't tested, but RX twice. PSC is not disabled when TX is idle
>
> Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
> ---
> diff --git a/sound/soc/au1x/psc-i2s.c b/sound/soc/au1x/psc-i2s.c
> index ba4b5c1..9384702 100644
> --- a/sound/soc/au1x/psc-i2s.c
> +++ b/sound/soc/au1x/psc-i2s.c
> @@ -231,7 +231,7 @@ static int au1xpsc_i2s_stop(struct au1xpsc_audio_data *pscdata, int stype)
>
> /* if both TX and RX are idle, disable PSC */
> stat = au_readl(I2S_STAT(pscdata));
> - if (!(stat & (PSC_I2SSTAT_RB | PSC_I2SSTAT_RB))) {
> + if (!(stat & (PSC_I2SSTAT_TB | PSC_I2SSTAT_RB))) {
> au_writel(0, I2S_CFG(pscdata));
> au_sync();
> au_writel(PSC_CTRL_SUSPEND, PSC_CTRL(pscdata));
Ah, stupid copy-paste error. Thanks!
Acked-by: Manuel Lauss <mano@roarinelk.homelinux.net>
--
Manuel Lauss
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] ALSA Au1xpsc: psc not disabled when TX is idle
2008-07-15 13:04 ` Manuel Lauss
@ 2008-07-15 13:09 ` Takashi Iwai
0 siblings, 0 replies; 3+ messages in thread
From: Takashi Iwai @ 2008-07-15 13:09 UTC (permalink / raw)
To: Manuel Lauss; +Cc: Roel Kluin, lkml
At Tue, 15 Jul 2008 15:04:29 +0200,
Manuel Lauss wrote:
>
> > au_sync();
> > au_writel(PSC_CTRL_SUSPEND, PSC_CTRL(pscdata));
>
> Ah, stupid copy-paste error. Thanks!
>
> Acked-by: Manuel Lauss <mano@roarinelk.homelinux.net>
Applied to sound tree now. Thanks.
Takashi
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2008-07-15 13:09 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-07-15 12:44 [PATCH] ALSA Au1xpsc: psc not disabled when TX is idle Roel Kluin
2008-07-15 13:04 ` Manuel Lauss
2008-07-15 13:09 ` Takashi Iwai
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.