All of lore.kernel.org
 help / color / mirror / Atom feed
From: Wolfgang Grandegger <wg@grandegger.com>
To: Jon Smirl <jonsmirl@gmail.com>
Cc: Jean Delvare <khali@linux-fr.org>, Linuxppc-dev@ozlabs.org
Subject: Re: [RFC] I2C: fsl-i2c: make device probing configurable via FDT
Date: Wed, 16 Jul 2008 15:09:24 +0200	[thread overview]
Message-ID: <487DF304.7090205@grandegger.com> (raw)
In-Reply-To: <9e4733910807160547q28f49865o11ec878d98987329@mail.gmail.com>

Jon Smirl wrote:
> On 7/16/08, Wolfgang Grandegger <wg@grandegger.com> wrote:
>> Currently, the I2C buses are probed for HWMON I2C devices, which might
>>  not be acceptable in same cases. This patch makes device probing
>>  configurable through the property "probe" of the FDT I2C device node:
> 
> All this patch seems to be doing is removing class I2C_CLASS_HWMON via
> a device tree flag, PROBE.

Yep.

> Why do you need to do this? The OF conversion patch that is working
> its way through the system lets you put the address of the device into
> the device tree node. Probing shouldn't be necessary at all.

Currently I2C_CLASS_HWMON is used for all I2C adapters and therefore 
probing is done even with a proper I2C node defined in the DTS file. 
That's what the patch is fixing leaving the possibility to (re-)enable 
legacy probing.

For some more details you may want to have a look to Jean's mail on that 
subject: http://ozlabs.org/pipermail/linuxppc-dev/2008-July/060012.html.

Wolfgang.

  reply	other threads:[~2008-07-16 13:09 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-07-16 10:47 [RFC] I2C: fsl-i2c: make device probing configurable via FDT Wolfgang Grandegger
2008-07-16 12:05 ` Jean Delvare
2008-07-16 13:03   ` Wolfgang Grandegger
2008-07-16 12:47 ` Jon Smirl
2008-07-16 13:09   ` Wolfgang Grandegger [this message]
2008-07-16 14:11     ` Jon Smirl
2008-07-16 14:24     ` Jon Smirl
2008-07-16 14:30       ` Grant Likely
2008-07-16 14:42         ` Jon Smirl
2008-07-16 15:01           ` Timur Tabi
2008-07-16 14:24 ` Grant Likely
2008-07-16 14:48   ` Jochen Friedrich
2008-07-16 20:20   ` Wolfgang Grandegger
2008-07-17 10:20     ` Is there relationship between address translation enabled and PLB timeout error? Evangelion

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=487DF304.7090205@grandegger.com \
    --to=wg@grandegger.com \
    --cc=Linuxppc-dev@ozlabs.org \
    --cc=jonsmirl@gmail.com \
    --cc=khali@linux-fr.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.