All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jochen Friedrich <jochen@scram.de>
To: Grant Likely <grant.likely@secretlab.ca>
Cc: Jean Delvare <khali@linux-fr.org>, Linuxppc-dev@ozlabs.org
Subject: Re: [RFC] I2C: fsl-i2c: make device probing configurable via FDT
Date: Wed, 16 Jul 2008 16:48:30 +0200	[thread overview]
Message-ID: <487E0A3E.80706@scram.de> (raw)
In-Reply-To: <20080716142436.GD24045@secretlab.ca>

Hi Grant,

> On Wed, Jul 16, 2008 at 12:47:25PM +0200, Wolfgang Grandegger wrote:
>> Currently, the I2C buses are probed for HWMON I2C devices, which might
>> not be acceptable in same cases. This patch makes device probing
>> configurable through the property "probe" of the FDT I2C device node:
>>
>>       i2c@3000 {
>>            ...
>>            compatible = "fsl-i2c";
>>            probe;
>> 	    ...
>>        };
> 
> You need to add documentation to booting-without-of.txt about what the
> 'probe' property means.  Also, 'probe' is a pretty generic term being
> used in an i2c specific context.  Can you prefix it with i2c or
> something to protect the namespace?  'i2c-probe' perhaps?

In i2c-cpm, I currently use the property "linux,i2c-class" to set the
i2c class directly as documented in dts-bindings/fsl/cpm_qe/cpm/i2c.txt.

We should agree on *one* method to set the i2c class.

Thanks,
Jochen

  reply	other threads:[~2008-07-16 14:48 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-07-16 10:47 [RFC] I2C: fsl-i2c: make device probing configurable via FDT Wolfgang Grandegger
2008-07-16 12:05 ` Jean Delvare
2008-07-16 13:03   ` Wolfgang Grandegger
2008-07-16 12:47 ` Jon Smirl
2008-07-16 13:09   ` Wolfgang Grandegger
2008-07-16 14:11     ` Jon Smirl
2008-07-16 14:24     ` Jon Smirl
2008-07-16 14:30       ` Grant Likely
2008-07-16 14:42         ` Jon Smirl
2008-07-16 15:01           ` Timur Tabi
2008-07-16 14:24 ` Grant Likely
2008-07-16 14:48   ` Jochen Friedrich [this message]
2008-07-16 20:20   ` Wolfgang Grandegger
2008-07-17 10:20     ` Is there relationship between address translation enabled and PLB timeout error? Evangelion

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=487E0A3E.80706@scram.de \
    --to=jochen@scram.de \
    --cc=Linuxppc-dev@ozlabs.org \
    --cc=grant.likely@secretlab.ca \
    --cc=khali@linux-fr.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.