[PATCH] ALSA: ac97: copy subsys values from the PCI device

[PATCH] ALSA: ac97: copy subsys values from the PCI device

[Rene Herman]

[-- Attachment #1: Type: text/plain, Size: 270 bytes --]

Hi.

Just getting to know to the code...

Why do we reread the subsys values from PCI config space in the AC97 code?

(this in addition to why we store the values in the ac97 struct in the 
first place if they're available through ac97->pci but that's secondary)

Rene.

[-- Attachment #2: 0001-ALSA-ac97-copy-subsys-values-from-the-PCI-device.patch --]
[-- Type: text/plain, Size: 1078 bytes --]

>From 01de5a42c7d5a0237895a476735028298203f30f Mon Sep 17 00:00:00 2001
From: Rene Herman <rene.herman@gmail.com>
Date: Thu, 17 Jul 2008 14:18:10 +0200
Subject: [PATCH] ALSA: ac97: copy subsys values from the PCI device

copy the subsys values from the PCI device instead of rereading them.

Signed-off-by: Rene Herman <rene.herman@gmail.com>
---
 sound/pci/ac97/ac97_codec.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/sound/pci/ac97/ac97_codec.c b/sound/pci/ac97/ac97_codec.c
index 45fd290..4f4343d 100644
--- a/sound/pci/ac97/ac97_codec.c
+++ b/sound/pci/ac97/ac97_codec.c
@@ -2015,8 +2015,8 @@ int snd_ac97_mixer(struct snd_ac97_bus *bus, struct snd_ac97_template *template,
 
 #ifdef CONFIG_PCI
 	if (ac97->pci) {
-		pci_read_config_word(ac97->pci, PCI_SUBSYSTEM_VENDOR_ID, &ac97->subsystem_vendor);
-		pci_read_config_word(ac97->pci, PCI_SUBSYSTEM_ID, &ac97->subsystem_device);
+		ac97->subsystem_vendor = ac97->pci->subsystem_vendor;
+		ac97->subsystem_device = ac97->pci->subsystem_device;
 	}
 #endif
 	if (bus->ops->reset) {
-- 
1.5.5


[-- Attachment #3: Type: text/plain, Size: 160 bytes --]

_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel

Re: [PATCH] ALSA: ac97: copy subsys values from the PCI device

[Takashi Iwai]

At Thu, 17 Jul 2008 14:24:32 +0200,
Rene Herman wrote:
> 
> >From 01de5a42c7d5a0237895a476735028298203f30f Mon Sep 17 00:00:00 2001
> From: Rene Herman <rene.herman@gmail.com>
> Date: Thu, 17 Jul 2008 14:18:10 +0200
> Subject: [PATCH] ALSA: ac97: copy subsys values from the PCI device
> 
> copy the subsys values from the PCI device instead of rereading them.
> 
> Signed-off-by: Rene Herman <rene.herman@gmail.com>
> ---
>  sound/pci/ac97/ac97_codec.c |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)

Well, it is still in that style just for laziness.  Changing to this
way requires the fix for 2.2/2.4 kernels, adding the chunk to the
patch, etc.

Anyway I'll apply it later.

Thanks,

Takashi

> 
> diff --git a/sound/pci/ac97/ac97_codec.c b/sound/pci/ac97/ac97_codec.c
> index 45fd290..4f4343d 100644
> --- a/sound/pci/ac97/ac97_codec.c
> +++ b/sound/pci/ac97/ac97_codec.c
> @@ -2015,8 +2015,8 @@ int snd_ac97_mixer(struct snd_ac97_bus *bus, struct snd_ac97_template *template,
>  
>  #ifdef CONFIG_PCI
>  	if (ac97->pci) {
> -		pci_read_config_word(ac97->pci, PCI_SUBSYSTEM_VENDOR_ID, &ac97->subsystem_vendor);
> -		pci_read_config_word(ac97->pci, PCI_SUBSYSTEM_ID, &ac97->subsystem_device);
> +		ac97->subsystem_vendor = ac97->pci->subsystem_vendor;
> +		ac97->subsystem_device = ac97->pci->subsystem_device;
>  	}
>  #endif
>  	if (bus->ops->reset) {
> -- 
> 1.5.5
> 

Re: [PATCH] ALSA: ac97: copy subsys values from the PCI device

[Rene Herman]

On 17-07-08 14:26, Takashi Iwai wrote:

> Well, it is still in that style just for laziness.  Changing to this
> way requires the fix for 2.2/2.4 kernels, adding the chunk to the
> patch, etc.
> 
> Anyway I'll apply it later.

Ah, I see. Don't bother changing it then I'd say. As said, just getting 
acquinted with the code...

Rene.