From: Vlad Yasevich <vladislav.yasevich@hp.com>
To: linux-sctp@vger.kernel.org
Subject: Re: SCTP_HMAC_NONE config variable is unused
Date: Thu, 17 Jul 2008 14:49:47 +0000 [thread overview]
Message-ID: <487F5C0B.80704@hp.com> (raw)
In-Reply-To: <alpine.LFD.1.10.0807171031190.6160@localhost.localdomain>
Robert P. J. Day wrote:
> that config variable is defined but unreferenced anywhere in the
> tree.
>
> rday
Yep. It could probably be use used here:
include/net/sctp/constants.h:
#if defined (CONFIG_SCTP_HMAC_MD5)
#define SCTP_COOKIE_HMAC_ALG "hmac(md5)"
#elif defined (CONFIG_SCTP_HMAC_SHA1)
#define SCTP_COOKIE_HMAC_ALG "hmac(sha1)"
#else
#define SCTP_COOKIE_HMAC_ALG NULL
#endif
the final '#else' can be:
#elif defined (CONFIG_SCTP_HMAC_NONE)
An alternative would be to change the 'choice' in Kconfig
to something else that allows us to have a 'none' selection.
Is this really a problem?
-vlad
next prev parent reply other threads:[~2008-07-17 14:49 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-17 14:32 SCTP_HMAC_NONE config variable is unused Robert P. J. Day
2008-07-17 14:49 ` Vlad Yasevich [this message]
2008-07-17 15:04 ` Robert P. J. Day
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=487F5C0B.80704@hp.com \
--to=vladislav.yasevich@hp.com \
--cc=linux-sctp@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.