* SCTP_HMAC_NONE config variable is unused
@ 2008-07-17 14:32 Robert P. J. Day
2008-07-17 14:49 ` Vlad Yasevich
2008-07-17 15:04 ` Robert P. J. Day
0 siblings, 2 replies; 3+ messages in thread
From: Robert P. J. Day @ 2008-07-17 14:32 UTC (permalink / raw)
To: linux-sctp
that config variable is defined but unreferenced anywhere in the
tree.
rday
--
====================================
Robert P. J. Day
Linux Consulting, Training and Annoying Kernel Pedantry:
Have classroom, will lecture.
http://crashcourse.ca Waterloo, Ontario, CANADA
====================================
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: SCTP_HMAC_NONE config variable is unused
2008-07-17 14:32 SCTP_HMAC_NONE config variable is unused Robert P. J. Day
@ 2008-07-17 14:49 ` Vlad Yasevich
2008-07-17 15:04 ` Robert P. J. Day
1 sibling, 0 replies; 3+ messages in thread
From: Vlad Yasevich @ 2008-07-17 14:49 UTC (permalink / raw)
To: linux-sctp
Robert P. J. Day wrote:
> that config variable is defined but unreferenced anywhere in the
> tree.
>
> rday
Yep. It could probably be use used here:
include/net/sctp/constants.h:
#if defined (CONFIG_SCTP_HMAC_MD5)
#define SCTP_COOKIE_HMAC_ALG "hmac(md5)"
#elif defined (CONFIG_SCTP_HMAC_SHA1)
#define SCTP_COOKIE_HMAC_ALG "hmac(sha1)"
#else
#define SCTP_COOKIE_HMAC_ALG NULL
#endif
the final '#else' can be:
#elif defined (CONFIG_SCTP_HMAC_NONE)
An alternative would be to change the 'choice' in Kconfig
to something else that allows us to have a 'none' selection.
Is this really a problem?
-vlad
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: SCTP_HMAC_NONE config variable is unused
2008-07-17 14:32 SCTP_HMAC_NONE config variable is unused Robert P. J. Day
2008-07-17 14:49 ` Vlad Yasevich
@ 2008-07-17 15:04 ` Robert P. J. Day
1 sibling, 0 replies; 3+ messages in thread
From: Robert P. J. Day @ 2008-07-17 15:04 UTC (permalink / raw)
To: linux-sctp
On Thu, 17 Jul 2008, Vlad Yasevich wrote:
> Robert P. J. Day wrote:
> > that config variable is defined but unreferenced anywhere in the
> > tree.
> >
> > rday
>
> Yep. It could probably be use used here:
>
> include/net/sctp/constants.h:
>
> #if defined (CONFIG_SCTP_HMAC_MD5)
> #define SCTP_COOKIE_HMAC_ALG "hmac(md5)"
> #elif defined (CONFIG_SCTP_HMAC_SHA1)
> #define SCTP_COOKIE_HMAC_ALG "hmac(sha1)"
> #else
> #define SCTP_COOKIE_HMAC_ALG NULL
> #endif
>
>
> the final '#else' can be:
>
> #elif defined (CONFIG_SCTP_HMAC_NONE)
>
>
> An alternative would be to change the 'choice' in Kconfig
> to something else that allows us to have a 'none' selection.
>
> Is this really a problem?
no, sorry, i just didn't look closely enough to note that it was a
default selection. just ignore that last noise.
rday
--
====================================
Robert P. J. Day
Linux Consulting, Training and Annoying Kernel Pedantry:
Have classroom, will lecture.
http://crashcourse.ca Waterloo, Ontario, CANADA
====================================
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2008-07-17 15:04 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-07-17 14:32 SCTP_HMAC_NONE config variable is unused Robert P. J. Day
2008-07-17 14:49 ` Vlad Yasevich
2008-07-17 15:04 ` Robert P. J. Day
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.