Re: [mmtom][BUGFIX] vmscan-second-chance-replacement-for-anonymous-pages-fix.patch

[Balbir Singh <balbir@linux.vnet.ibm.com>]

KAMEZAWA Hiroyuki wrote:
> Under memcg, active anon tend not to go to inactive anon.
> This will cause OOM in memcg easily when tons of anon was used at once.
> This check was lacked in split-lru.
> 
> This patch is a fix agaisnt
> vmscan-second-chance-replacement-for-anonymous-pages.patch
> 
> 
> Changelog: v1 -> v2:
>  - avoid adding "else".
> 
> Signed-off-by:KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
> Acked-by: Rik van Riel <riel@redhat.com>
> 
>  mm/vmscan.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> Index: mmtom-stamp-2008-07-15-15-39/mm/vmscan.c
> ===================================================================
> --- mmtom-stamp-2008-07-15-15-39.orig/mm/vmscan.c
> +++ mmtom-stamp-2008-07-15-15-39/mm/vmscan.c
> @@ -1351,7 +1351,7 @@ static unsigned long shrink_zone(int pri
>  	 * Even if we did not try to evict anon pages at all, we want to
>  	 * rebalance the anon lru active/inactive ratio.
>  	 */
> -	if (scan_global_lru(sc) && inactive_anon_is_low(zone))
> +	if (!scan_global_lru(sc) || inactive_anon_is_low(zone))
>  		shrink_active_list(SWAP_CLUSTER_MAX, zone, sc, priority, 0);
> 
>  	throttle_vm_writeout(sc->gfp_mask);

I have not seen this, but looks good to me

Acked-by: Balbir Singh <balbir@linux.vnet.ibm.com>

-- 
	Warm Regards,
	Balbir Singh
	Linux Technology Center
	IBM, ISTL