From: John Reiser <jreiser@BitWagon.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: linux-kernel@vger.kernel.org, linuxppc-dev@ozlabs.org,
Nathan Lynch <ntl@pobox.com>,
torvalds@linux-foundation.org, roland@redhat.com
Subject: Re: [PATCH v3] elf loader support for auxvec base platform string
Date: Thu, 17 Jul 2008 16:35:40 -0700 [thread overview]
Message-ID: <487FD74C.4080603@BitWagon.com> (raw)
In-Reply-To: <20080717154218.8981035c.akpm@linux-foundation.org>
Andrew Morton wrote:
> On Thu, 17 Jul 2008 17:19:32 -0500
> Nathan Lynch <ntl@pobox.com> wrote:
>
>
>> [snip]
>> A new aux vector entry, AT_BASE_PLATFORM, will denote the actual hardware.
[snip]
> OK.
>
> But it conflicts directly with the already-queued
> execve-filename-document-and-export-via-auxiliary-vector.patch
[snip]
It seems to me that most of the patch conflicts are mechanical
and could be merged mechanically.
However I believe that the documentation change to this comment is important:
-----
> #ifdef __KERNEL__
> -#define AT_VECTOR_SIZE_BASE (14 + 2) /* NEW_AUX_ENT entries in auxiliary table */
> +#define AT_VECTOR_SIZE_BASE 17 /* NEW_AUX_ENT entries in auxiliary table */
> + /* number of "#define AT_.*" above, minus {AT_NULL, AT_IGNORE, AT_NOTELF} */
> #endif
-----
I scratched my head for a while to figure out that AT_NOTELF also was
a subtraction as far as AT_VECTOR_SIZE_BASE was concerned.
--
John Reiser, jreiser@BitWagon.com
WARNING: multiple messages have this Message-ID (diff)
From: John Reiser <jreiser@BitWagon.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Nathan Lynch <ntl@pobox.com>,
benh@kernel.crashing.org, torvalds@linux-foundation.org,
linuxppc-dev@ozlabs.org, linux-kernel@vger.kernel.org,
roland@redhat.com
Subject: Re: [PATCH v3] elf loader support for auxvec base platform string
Date: Thu, 17 Jul 2008 16:35:40 -0700 [thread overview]
Message-ID: <487FD74C.4080603@BitWagon.com> (raw)
In-Reply-To: <20080717154218.8981035c.akpm@linux-foundation.org>
Andrew Morton wrote:
> On Thu, 17 Jul 2008 17:19:32 -0500
> Nathan Lynch <ntl@pobox.com> wrote:
>
>
>> [snip]
>> A new aux vector entry, AT_BASE_PLATFORM, will denote the actual hardware.
[snip]
> OK.
>
> But it conflicts directly with the already-queued
> execve-filename-document-and-export-via-auxiliary-vector.patch
[snip]
It seems to me that most of the patch conflicts are mechanical
and could be merged mechanically.
However I believe that the documentation change to this comment is important:
-----
> #ifdef __KERNEL__
> -#define AT_VECTOR_SIZE_BASE (14 + 2) /* NEW_AUX_ENT entries in auxiliary table */
> +#define AT_VECTOR_SIZE_BASE 17 /* NEW_AUX_ENT entries in auxiliary table */
> + /* number of "#define AT_.*" above, minus {AT_NULL, AT_IGNORE, AT_NOTELF} */
> #endif
-----
I scratched my head for a while to figure out that AT_NOTELF also was
a subtraction as far as AT_VECTOR_SIZE_BASE was concerned.
--
John Reiser, jreiser@BitWagon.com
next prev parent reply other threads:[~2008-07-17 23:44 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-15 23:58 AT_BASE_PLATFORM (v2) Nathan Lynch
2008-07-15 23:58 ` [PATCH] elf loader support for auxvec base platform string Nathan Lynch
2008-07-17 6:35 ` Benjamin Herrenschmidt
2008-07-17 6:35 ` Benjamin Herrenschmidt
2008-07-17 7:09 ` Andrew Morton
2008-07-17 7:09 ` Andrew Morton
2008-07-17 17:39 ` Nathan Lynch
2008-07-17 17:39 ` Nathan Lynch
2008-07-17 22:19 ` [PATCH v3] " Nathan Lynch
2008-07-17 22:19 ` Nathan Lynch
2008-07-17 22:42 ` Andrew Morton
2008-07-17 22:42 ` Andrew Morton
2008-07-17 23:35 ` John Reiser [this message]
2008-07-17 23:35 ` John Reiser
2008-07-18 18:28 ` Nathan Lynch
2008-07-18 18:28 ` Nathan Lynch
2008-07-18 20:31 ` John Reiser
2008-07-18 20:31 ` John Reiser
2008-07-18 20:52 ` Andrew Morton
2008-07-18 20:52 ` Andrew Morton
2008-07-21 3:24 ` Benjamin Herrenschmidt
2008-07-21 3:24 ` Benjamin Herrenschmidt
2008-07-21 3:40 ` Andrew Morton
2008-07-21 3:40 ` Andrew Morton
2008-07-21 9:33 ` Benjamin Herrenschmidt
2008-07-21 9:33 ` Benjamin Herrenschmidt
2008-07-21 18:48 ` [PATCH v4] " Nathan Lynch
2008-07-21 18:48 ` Nathan Lynch
2008-07-22 2:03 ` Benjamin Herrenschmidt
2008-07-22 2:03 ` Benjamin Herrenschmidt
2008-07-17 16:10 ` [PATCH] " Linus Torvalds
2008-07-17 16:10 ` Linus Torvalds
2008-07-17 19:35 ` Nathan Lynch
2008-07-17 19:35 ` Nathan Lynch
2008-07-21 3:19 ` Benjamin Herrenschmidt
2008-07-21 3:19 ` Benjamin Herrenschmidt
2008-07-15 23:58 ` [PATCH] enable AT_BASE_PLATFORM aux vector for powerpc Nathan Lynch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=487FD74C.4080603@BitWagon.com \
--to=jreiser@bitwagon.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=ntl@pobox.com \
--cc=roland@redhat.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.