* [PATCH] x86: reduce forbid_dac's visibility
@ 2008-07-18 12:44 Jan Beulich
2008-07-18 21:39 ` H. Peter Anvin
0 siblings, 1 reply; 2+ messages in thread
From: Jan Beulich @ 2008-07-18 12:44 UTC (permalink / raw)
To: mingo, tglx, hpa; +Cc: linux-kernel
It's not used anywhere outside its declaring file.
Signed-off-by: Jan Beulich <jbeulich@novell.com>
---
arch/x86/kernel/pci-dma.c | 3 +--
include/asm-x86/dma-mapping.h | 1 -
2 files changed, 1 insertion(+), 3 deletions(-)
--- linux-2.6.26/arch/x86/kernel/pci-dma.c 2008-07-13 23:51:29.000000000 +0200
+++ 2.6.26-x86-forbid-dac/arch/x86/kernel/pci-dma.c 2008-07-15 14:51:28.000000000 +0200
@@ -8,8 +8,7 @@
#include <asm/gart.h>
#include <asm/calgary.h>
-int forbid_dac __read_mostly;
-EXPORT_SYMBOL(forbid_dac);
+static int forbid_dac __read_mostly;
const struct dma_mapping_ops *dma_ops;
EXPORT_SYMBOL(dma_ops);
--- linux-2.6.26/include/asm-x86/dma-mapping.h 2008-07-13 23:51:29.000000000 +0200
+++ 2.6.26-x86-forbid-dac/include/asm-x86/dma-mapping.h 2008-07-17 10:29:09.000000000 +0200
@@ -14,7 +14,6 @@ extern dma_addr_t bad_dma_address;
extern int iommu_merge;
extern struct device fallback_dev;
extern int panic_on_overflow;
-extern int forbid_dac;
extern int force_iommu;
struct dma_mapping_ops {
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] x86: reduce forbid_dac's visibility
2008-07-18 12:44 [PATCH] x86: reduce forbid_dac's visibility Jan Beulich
@ 2008-07-18 21:39 ` H. Peter Anvin
0 siblings, 0 replies; 2+ messages in thread
From: H. Peter Anvin @ 2008-07-18 21:39 UTC (permalink / raw)
To: Jan Beulich; +Cc: mingo, tglx, linux-kernel
Jan Beulich wrote:
> It's not used anywhere outside its declaring file.
>
> Signed-off-by: Jan Beulich <jbeulich@novell.com>
>
> ---
> arch/x86/kernel/pci-dma.c | 3 +--
> include/asm-x86/dma-mapping.h | 1 -
> 2 files changed, 1 insertion(+), 3 deletions(-)
Manually applied to x86/cleanups, thanks.
-hpa
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2008-07-18 21:40 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-07-18 12:44 [PATCH] x86: reduce forbid_dac's visibility Jan Beulich
2008-07-18 21:39 ` H. Peter Anvin
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.