* Re: [PATCH] V4L: Link tuner before saa7134
@ 2008-07-18 11:28 Brian Marete
2008-07-18 11:51 ` [linux-dvb] " Simon Arlott
0 siblings, 1 reply; 7+ messages in thread
From: Brian Marete @ 2008-07-18 11:28 UTC (permalink / raw)
To: LKML
On Jul 14, 6:00 am, hermann pitton <hermann-pit...@arcor.de> wrote:
>
> #1 users can't set thetunertype anymore,
> but the few cases oftunerdetection from eeprom we have should
> work again for that price.
Hello,
Any patch yet for above issue? It seems to have made it into 2.6.26.
I use saa7134 with everything, including the tuner modules, compiled
as a module. My card is detected as a flyvideo2000. The default tuner
for that card (#37) allows me to tune into TV but not to FM Radio. I
can access both functions (TV and FM Radio) if I override with
tuner=69, which is what I usually do. That override does not work on
2.6.26.
Any suggestions?
Thanks,
--
B. Gitonga Marete
Tel: +254-722-151-590
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH] V4L: Link tuner before saa7134 2008-07-18 11:28 [PATCH] V4L: Link tuner before saa7134 Brian Marete @ 2008-07-18 11:51 ` Simon Arlott 0 siblings, 0 replies; 7+ messages in thread From: Simon Arlott @ 2008-07-18 11:51 UTC (permalink / raw) To: Brian Marete; +Cc: LKML, linux-dvb On Fri, July 18, 2008 12:28, Brian Marete wrote: > On Jul 14, 6:00 am, hermann pitton <hermann-pit...@arcor.de> wrote: >> >> #1 users can't set thetunertype anymore, >> but the few cases oftunerdetection from eeprom we have should >> work again for that price. > > Hello, > > Any patch yet for above issue? It seems to have made it into 2.6.26. > > I use saa7134 with everything, including the tuner modules, compiled > as a module. My card is detected as a flyvideo2000. The default tuner > for that card (#37) allows me to tune into TV but not to FM Radio. I > can access both functions (TV and FM Radio) if I override with > tuner=69, which is what I usually do. That override does not work on > 2.6.26. > > Any suggestions? Modify saa7134_board_init2 so that the manual tuner type setting isn't ignored. The first thing it does is to overwrite the current value (set earlier from module parameter) with the static values... even before trying to autodetect it. In saa7134-core.c saa7134_initdev: dev->tuner_type = saa7134_boards[dev->board].tuner_type; +dev->tuner_addr = saa7134_boards[dev->board].tuner_addr; In saa7134-cards.c saa7134_board_init2: -dev->tuner_type = saa7134_boards[dev->board].tuner_type; -dev->tuner_addr = saa7134_boards[dev->board].tuner_addr; I think that will fix it. > > Thanks, > > -- > B. Gitonga Marete > Tel: +254-722-151-590 > -- > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/ > -- Simon Arlott ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [linux-dvb] [PATCH] V4L: Link tuner before saa7134 @ 2008-07-18 11:51 ` Simon Arlott 0 siblings, 0 replies; 7+ messages in thread From: Simon Arlott @ 2008-07-18 11:51 UTC (permalink / raw) To: Brian Marete; +Cc: linux-dvb, LKML On Fri, July 18, 2008 12:28, Brian Marete wrote: > On Jul 14, 6:00 am, hermann pitton <hermann-pit...@arcor.de> wrote: >> >> #1 users can't set thetunertype anymore, >> but the few cases oftunerdetection from eeprom we have should >> work again for that price. > > Hello, > > Any patch yet for above issue? It seems to have made it into 2.6.26. > > I use saa7134 with everything, including the tuner modules, compiled > as a module. My card is detected as a flyvideo2000. The default tuner > for that card (#37) allows me to tune into TV but not to FM Radio. I > can access both functions (TV and FM Radio) if I override with > tuner=69, which is what I usually do. That override does not work on > 2.6.26. > > Any suggestions? Modify saa7134_board_init2 so that the manual tuner type setting isn't ignored. The first thing it does is to overwrite the current value (set earlier from module parameter) with the static values... even before trying to autodetect it. In saa7134-core.c saa7134_initdev: dev->tuner_type = saa7134_boards[dev->board].tuner_type; +dev->tuner_addr = saa7134_boards[dev->board].tuner_addr; In saa7134-cards.c saa7134_board_init2: -dev->tuner_type = saa7134_boards[dev->board].tuner_type; -dev->tuner_addr = saa7134_boards[dev->board].tuner_addr; I think that will fix it. > > Thanks, > > -- > B. Gitonga Marete > Tel: +254-722-151-590 > -- > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/ > -- Simon Arlott _______________________________________________ linux-dvb mailing list linux-dvb@linuxtv.org http://www.linuxtv.org/cgi-bin/mailman/listinfo/linux-dvb ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [linux-dvb] [PATCH] V4L: Link tuner before saa7134 2008-07-18 11:51 ` [linux-dvb] " Simon Arlott @ 2008-07-18 22:56 ` hermann pitton -1 siblings, 0 replies; 7+ messages in thread From: hermann pitton @ 2008-07-18 22:56 UTC (permalink / raw) To: Simon Arlott, video4linux-list, v4l-dvb list, Mauro Carvalho Chehab Cc: Brian Marete, linux-dvb, LKML Hi, Am Freitag, den 18.07.2008, 12:51 +0100 schrieb Simon Arlott: > On Fri, July 18, 2008 12:28, Brian Marete wrote: > > On Jul 14, 6:00 am, hermann pitton <hermann-pit...@arcor.de> wrote: > >> > >> #1 users can't set thetunertype anymore, > >> but the few cases oftunerdetection from eeprom we have should > >> work again for that price. > > > > Hello, > > > > Any patch yet for above issue? It seems to have made it into 2.6.26. > > > > I use saa7134 with everything, including the tuner modules, compiled > > as a module. My card is detected as a flyvideo2000. The default tuner > > for that card (#37) allows me to tune into TV but not to FM Radio. I > > can access both functions (TV and FM Radio) if I override with > > tuner=69, which is what I usually do. That override does not work on > > 2.6.26. > > > > Any suggestions? > > Modify saa7134_board_init2 so that the manual tuner type setting isn't > ignored. The first thing it does is to overwrite the current value > (set earlier from module parameter) with the static values... even > before trying to autodetect it. > > In saa7134-core.c saa7134_initdev: > dev->tuner_type = saa7134_boards[dev->board].tuner_type; > +dev->tuner_addr = saa7134_boards[dev->board].tuner_addr; > > In saa7134-cards.c saa7134_board_init2: > -dev->tuner_type = saa7134_boards[dev->board].tuner_type; > -dev->tuner_addr = saa7134_boards[dev->board].tuner_addr; > > I think that will fix it. > this restores tuner behavior on the saa7134 driver. I can't test XCeive tuners, which load different firmware dynamically. Mauro was on them. Please send the patch to Mauro and/or provide your signed-off-by. This must go to the stable team ASAP as well. Reviewed-by: Hermann Pitton <hermann-pitton@arcor.de> Many thanks! Cheers, Hermann ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [linux-dvb] [PATCH] V4L: Link tuner before saa7134 @ 2008-07-18 22:56 ` hermann pitton 0 siblings, 0 replies; 7+ messages in thread From: hermann pitton @ 2008-07-18 22:56 UTC (permalink / raw) To: Simon Arlott, video4linux-list, v4l-dvb list, Mauro Carvalho Chehab Cc: linux-dvb, Brian Marete, LKML Hi, Am Freitag, den 18.07.2008, 12:51 +0100 schrieb Simon Arlott: > On Fri, July 18, 2008 12:28, Brian Marete wrote: > > On Jul 14, 6:00 am, hermann pitton <hermann-pit...@arcor.de> wrote: > >> > >> #1 users can't set thetunertype anymore, > >> but the few cases oftunerdetection from eeprom we have should > >> work again for that price. > > > > Hello, > > > > Any patch yet for above issue? It seems to have made it into 2.6.26. > > > > I use saa7134 with everything, including the tuner modules, compiled > > as a module. My card is detected as a flyvideo2000. The default tuner > > for that card (#37) allows me to tune into TV but not to FM Radio. I > > can access both functions (TV and FM Radio) if I override with > > tuner=69, which is what I usually do. That override does not work on > > 2.6.26. > > > > Any suggestions? > > Modify saa7134_board_init2 so that the manual tuner type setting isn't > ignored. The first thing it does is to overwrite the current value > (set earlier from module parameter) with the static values... even > before trying to autodetect it. > > In saa7134-core.c saa7134_initdev: > dev->tuner_type = saa7134_boards[dev->board].tuner_type; > +dev->tuner_addr = saa7134_boards[dev->board].tuner_addr; > > In saa7134-cards.c saa7134_board_init2: > -dev->tuner_type = saa7134_boards[dev->board].tuner_type; > -dev->tuner_addr = saa7134_boards[dev->board].tuner_addr; > > I think that will fix it. > this restores tuner behavior on the saa7134 driver. I can't test XCeive tuners, which load different firmware dynamically. Mauro was on them. Please send the patch to Mauro and/or provide your signed-off-by. This must go to the stable team ASAP as well. Reviewed-by: Hermann Pitton <hermann-pitton@arcor.de> Many thanks! Cheers, Hermann -- video4linux-list mailing list Unsubscribe mailto:video4linux-list-request@redhat.com?subject=unsubscribe https://www.redhat.com/mailman/listinfo/video4linux-list ^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH] saa7134: Copy tuner data earlier in init to avoid overwriting manual tuner type 2008-07-18 22:56 ` hermann pitton (?) @ 2008-07-19 2:16 ` Simon Arlott -1 siblings, 0 replies; 7+ messages in thread From: Simon Arlott @ 2008-07-19 2:16 UTC (permalink / raw) To: linux-dvb Cc: hermann pitton, video4linux-list, v4l-dvb list, Mauro Carvalho Chehab, Brian Marete, LKML When saa7134_board_init2 runs, it immediately overwrites the current value (set earlier from module parameter) of tuner_type with the static values, and then does autodetection. This patch moves the tuner_addr copy to earlier in saa7134_initdev and removes the tuner_type copy from saa7134_board_init2. Autodetection could still potentially change to the wrong tuner type, but it is now possible to override the default type for the card again. My card's tuner is configured with autodetection from eeprom, so I don't need to manually set the tuner. I've checked that the autodetection still works for my card. Reviewed-by: Hermann Pitton <hermann-pitton@arcor.de> Cc: Brian Marete <bgmarete@gmail.com> Tested-by: Simon Arlott <simon@fire.lp0.eu> Signed-off-by: Simon Arlott <simon@fire.lp0.eu> --- > this restores tuner behavior on the saa7134 driver. > > I can't test XCeive tuners, which load different firmware dynamically. > Mauro was on them. > > Please send the patch to Mauro and/or provide your signed-off-by. > > This must go to the stable team ASAP as well. > > Reviewed-by: Hermann Pitton <hermann-pitton@arcor.de> drivers/media/video/saa7134/saa7134-cards.c | 3 --- drivers/media/video/saa7134/saa7134-core.c | 5 +++-- 2 files changed, 3 insertions(+), 5 deletions(-) diff --git a/drivers/media/video/saa7134/saa7134-cards.c b/drivers/media/video/saa7134/saa7134-cards.c index 2618cfa..0227cf9 100644 --- a/drivers/media/video/saa7134/saa7134-cards.c +++ b/drivers/media/video/saa7134/saa7134-cards.c @@ -5703,9 +5703,6 @@ int saa7134_board_init2(struct saa7134_dev *dev) unsigned char buf; int board; - dev->tuner_type = saa7134_boards[dev->board].tuner_type; - dev->tuner_addr = saa7134_boards[dev->board].tuner_addr; - switch (dev->board) { case SAA7134_BOARD_BMK_MPEX_NOTUNER: case SAA7134_BOARD_BMK_MPEX_TUNER: diff --git a/drivers/media/video/saa7134/saa7134-core.c b/drivers/media/video/saa7134/saa7134-core.c index 2c19cd0..69f340d 100644 --- a/drivers/media/video/saa7134/saa7134-core.c +++ b/drivers/media/video/saa7134/saa7134-core.c @@ -946,11 +946,12 @@ static int __devinit saa7134_initdev(struct pci_dev *pci_dev, dev->board = SAA7134_BOARD_UNKNOWN; } dev->autodetected = card[dev->nr] != dev->board; - dev->tuner_type = saa7134_boards[dev->board].tuner_type; + dev->tuner_type = saa7134_boards[dev->board].tuner_type; + dev->tuner_addr = saa7134_boards[dev->board].tuner_addr; dev->tda9887_conf = saa7134_boards[dev->board].tda9887_conf; if (UNSET != tuner[dev->nr]) dev->tuner_type = tuner[dev->nr]; - printk(KERN_INFO "%s: subsystem: %04x:%04x, board: %s [card=%d,%s]\n", + printk(KERN_INFO "%s: subsystem: %04x:%04x, board: %s [card=%d,%s]\n", dev->name,pci_dev->subsystem_vendor, pci_dev->subsystem_device,saa7134_boards[dev->board].name, dev->board, dev->autodetected ? -- 1.5.6.2 -- Simon Arlott ^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH] V4L: Link tuner before saa7134 2008-07-18 11:51 ` [linux-dvb] " Simon Arlott (?) (?) @ 2008-07-21 12:34 ` Brian Marete -1 siblings, 0 replies; 7+ messages in thread From: Brian Marete @ 2008-07-21 12:34 UTC (permalink / raw) To: Simon Arlott; +Cc: LKML, linux-dvb On Fri, Jul 18, 2008 at 2:51 PM, Simon Arlott <simon@fire.lp0.eu> wrote: > > On Fri, July 18, 2008 12:28, Brian Marete wrote: >> On Jul 14, 6:00 am, hermann pitton <hermann-pit...@arcor.de> wrote: >>> >>> #1 users can't set thetunertype anymore, >>> but the few cases oftunerdetection from eeprom we have should >>> work again for that price. >> >> Hello, >> >> Any patch yet for above issue? It seems to have made it into 2.6.26. >> >> I use saa7134 with everything, including the tuner modules, compiled >> as a module. My card is detected as a flyvideo2000. The default tuner >> for that card (#37) allows me to tune into TV but not to FM Radio. I >> can access both functions (TV and FM Radio) if I override with >> tuner=69, which is what I usually do. That override does not work on >> 2.6.26. >> >> Any suggestions? > > Modify saa7134_board_init2 so that the manual tuner type setting isn't > ignored. The first thing it does is to overwrite the current value > (set earlier from module parameter) with the static values... even > before trying to autodetect it. > > In saa7134-core.c saa7134_initdev: > dev->tuner_type = saa7134_boards[dev->board].tuner_type; > +dev->tuner_addr = saa7134_boards[dev->board].tuner_addr; > > In saa7134-cards.c saa7134_board_init2: > -dev->tuner_type = saa7134_boards[dev->board].tuner_type; > -dev->tuner_addr = saa7134_boards[dev->board].tuner_addr; > > I think that will fix it. And, indeed, it fixed it. I hope the patch will make it into the main-line. Thanks. -- B. Gitonga Marete Tel: +254-722-151-590 ^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2008-07-21 12:34 UTC | newest] Thread overview: 7+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2008-07-18 11:28 [PATCH] V4L: Link tuner before saa7134 Brian Marete 2008-07-18 11:51 ` Simon Arlott 2008-07-18 11:51 ` [linux-dvb] " Simon Arlott 2008-07-18 22:56 ` hermann pitton 2008-07-18 22:56 ` hermann pitton 2008-07-19 2:16 ` [PATCH] saa7134: Copy tuner data earlier in init to avoid overwriting manual tuner type Simon Arlott 2008-07-21 12:34 ` [PATCH] V4L: Link tuner before saa7134 Brian Marete
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.