[PATCH]Set SCI_EN when resuming from S3

[PATCH]Set SCI_EN when resuming from S3

[Chen, Huacai]

[-- Attachment #1: Type: text/plain, Size: 274 bytes --]

Hi, Keir

This patch is for Dom0.
When resuming from S3, some platforms may clear SCI_EN bit in
PM1_CONTROL register and cause SCI interrupt disabled in Domain0. This
patch fixes this issue as Linux-2.6.19 does. 

Signed-off-by:  Huacai Chen <huacai.chen@intel.com>

[-- Attachment #2: s3_dom0_sci.patch --]
[-- Type: application/octet-stream, Size: 1000 bytes --]

diff -r 3044873a84b7 drivers/acpi/hardware/hwregs.c
--- a/drivers/acpi/hardware/hwregs.c	Tue May 13 10:28:48 2008 +0100
+++ b/drivers/acpi/hardware/hwregs.c	Thu Jun 12 20:59:04 2008 +0800
@@ -665,8 +665,6 @@ acpi_status acpi_hw_register_write(u8 us
 
 		/*
 		 * Perform a read first to preserve certain bits (per ACPI spec)
-		 *
-		 * Note: This includes SCI_EN, we never want to change this bit
 		 */
 		status = acpi_hw_register_read(ACPI_MTX_DO_NOT_LOCK,
 					       ACPI_REGISTER_PM1_CONTROL,
diff -r 3044873a84b7 include/acpi/aclocal.h
--- a/include/acpi/aclocal.h	Tue May 13 10:28:48 2008 +0100
+++ b/include/acpi/aclocal.h	Thu Jun 12 20:59:04 2008 +0800
@@ -708,7 +708,7 @@ struct acpi_bit_register_info {
  * must be preserved.
  */
 #define ACPI_PM1_STATUS_PRESERVED_BITS          0x0800	/* Bit 11 */
-#define ACPI_PM1_CONTROL_PRESERVED_BITS         0x0201	/* Bit 9, Bit 0 (SCI_EN) */
+#define ACPI_PM1_CONTROL_PRESERVED_BITS         0x0200	/* Bit 9 (whatever) */
 
 /*
  * Register IDs

[-- Attachment #3: Type: text/plain, Size: 138 bytes --]

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel

Re: [PATCH]Set SCI_EN when resuming from S3

[Jan Beulich]

>>> "Chen, Huacai" <huacai.chen@intel.com> 20.07.08 04:52 >>>
>Hi, Keir
>
>This patch is for Dom0.
>When resuming from S3, some platforms may clear SCI_EN bit in
>PM1_CONTROL register and cause SCI interrupt disabled in Domain0. This
>patch fixes this issue as Linux-2.6.19 does. 
>
>Signed-off-by:  Huacai Chen <huacai.chen@intel.com>

It seems like this is (part of) an upstream commit, so I think it would be
appropriate to indicate which commit this was (and ideally also when
approximately it happened). This helps  clarifying the testing status and
identifying the applicability to derived trees.

Thanks, Jan