All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jean Guyader <jean.guyader@eu.citrix.com>
To: Trolle Selander <trolle.selander@gmail.com>
Cc: xen-devel <xen-devel@lists.xensource.com>,
	Ian Jackson <Ian.Jackson@eu.citrix.com>
Subject: Re: Re: [PATCH] ioemu-remote: ACPI S3 state wake up
Date: Thu, 24 Jul 2008 11:48:40 +0100	[thread overview]
Message-ID: <48885E08.4050603@eu.citrix.com> (raw)
In-Reply-To: <515922b50807240323k99474dfnb679c40290a8aa11@mail.gmail.com>

I already tried to reduce the rw area, and just keep 0xe0 -> 0xef. But 
obviously it doesn't work the device model needs to write on this frame 
0xf1. I still don't figure out why.


Trolle Selander wrote:
> Don't leave the main rombios unprotected. I also added a comment to 
> explain the "magic numbers", since their meaning is perhaps not as 
> obvious as I thought, in particular now that we're no longer 
> blanket-protecting the entire firmware area anymore.
> 
> / Trolle
> 
> Signed-off-by: Trolle Selander <trolle.selander@eu.citrix.com 
> <mailto:trolle.selander@eu.citrix.com> 
> <mailto:trolle.selander@eu.citrix.com>
> 
> On Wed, Jul 23, 2008 at 7:02 PM, Ian Jackson <Ian.Jackson@eu.citrix.com 
> <mailto:Ian.Jackson@eu.citrix.com>> wrote:
> 
>     Jean Guyader writes ("[PATCH] ioemu-remote: ACPI S3 state wake up"):
>      > ioemu-remote: The device model needs to write in the ACPI tables
>     when it
>      > wakes up from S3 state.
> 
>     I've applied this but I have to say these magic numbers
>      > -        if (xc_hvm_set_mem_type(xc_handle, domid, mem_type,
>     0xc0, 0x40))
>      > +        if (xc_hvm_set_mem_type(xc_handle, domid, mem_type,
>     0xc0, 0x20))
>     are pretty unpleasant!  Are they directly derived from addresses
>     specified in ACPI ?  I haven't looked ...
> 
>     Ian.
> 
>     _______________________________________________
>     Xen-devel mailing list
>     Xen-devel@lists.xensource.com <mailto:Xen-devel@lists.xensource.com>
>     http://lists.xensource.com/xen-devel
> 
> 


-- 
Jean Guyader

  parent reply	other threads:[~2008-07-24 10:48 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-07-23 17:51 [PATCH] ioemu-remote: ACPI S3 state wake up Jean Guyader
2008-07-23 18:02 ` Ian Jackson
2008-07-24 10:23   ` Trolle Selander
2008-07-24 10:35     ` Ian Jackson
2008-07-24 10:48     ` Jean Guyader [this message]
2008-07-24 12:12       ` Jean Guyader
2008-07-24 12:45         ` Keir Fraser
2008-07-24 12:54           ` Trolle Selander
2008-07-24 12:57             ` Keir Fraser
2008-07-29  9:47           ` Ke, Liping
2008-07-29  9:53             ` Keir Fraser
2008-07-29 10:26               ` Keir Fraser
2008-07-29 10:39                 ` Ke, Liping
2008-07-29 10:40                 ` Trolle Selander
2008-07-29 11:22                   ` Ke, Liping
2008-07-29 11:50                     ` Keir Fraser
2008-07-29 11:50                   ` Keir Fraser
2008-07-29 11:58                     ` Keir Fraser
2008-07-29 15:11                 ` Keir Fraser
2008-07-30  2:51                   ` Ke, Liping
2008-07-30  3:09                     ` Tian, Kevin
2008-07-30  4:48                       ` Ke, Liping
2008-07-30 11:44                         ` Ke, Liping
2008-07-30 12:01                           ` Keir Fraser
2008-07-30 11:50                         ` Ke, Liping
2008-07-30 12:05                           ` Keir Fraser
2008-07-31 10:25                             ` Ke, Liping
2008-07-31 10:28                               ` Jean Guyader
2008-07-31 10:43                               ` Keir Fraser

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=48885E08.4050603@eu.citrix.com \
    --to=jean.guyader@eu.citrix.com \
    --cc=Ian.Jackson@eu.citrix.com \
    --cc=trolle.selander@gmail.com \
    --cc=xen-devel@lists.xensource.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.