Getting GPIO to build again

Getting GPIO to build again

[Jon Smirl]

I just synced up to linus/master....

  CC      arch/powerpc/platforms/52xx/mpc52xx_gpio.o
In file included from arch/powerpc/platforms/52xx/mpc52xx_gpio.c:22:
include/linux/of_gpio.h:26: error: field 'gc' has incomplete type
include/linux/of_gpio.h: In function 'to_of_gpio_chip':
include/linux/of_gpio.h:34: warning: type defaults to 'int' in
declaration of '__mptr'
include/linux/of_gpio.h:34: warning: initialization from incompatible
pointer type
In file included from include/asm/gpio.h:18,
                 from arch/powerpc/platforms/52xx/mpc52xx_gpio.c:26:
include/asm-generic/gpio.h: At top level:
include/asm-generic/gpio.h:24: error: redefinition of 'gpio_is_valid'
include/linux/gpio.h:24: error: previous definition of 'gpio_is_valid' was here
In file included from arch/powerpc/platforms/52xx/mpc52xx_gpio.c:26:
include/asm/gpio.h:27: error: redefinition of 'gpio_get_value'
include/linux/gpio.h:50: error: previous definition of 'gpio_get_value' was here
include/asm/gpio.h:32: error: redefinition of 'gpio_set_value'
include/linux/gpio.h:57: error: previous definition of 'gpio_set_value' was here
include/asm/gpio.h:37: error: redefinition of 'gpio_cansleep'
include/linux/gpio.h:63: error: previous definition of 'gpio_cansleep' was here
include/asm/gpio.h:45: error: redefinition of 'gpio_to_irq'
include/linux/gpio.h:83: error: previous definition of 'gpio_to_irq' was here
include/asm/gpio.h:50: error: redefinition of 'irq_to_gpio'
include/linux/gpio.h:90: error: previous definition of 'irq_to_gpio' was here
make[2]: *** [arch/powerpc/platforms/52xx/mpc52xx_gpio.o] Error 1
make[1]: *** [arch/powerpc/platforms/52xx] Error 2
make: *** [arch/powerpc/platforms] Error 2


-- 
Jon Smirl
jonsmirl@gmail.com

Re: Getting GPIO to build again

[Jon Smirl]

This lets me build again, no clue if it is the correct fix.

diff --git a/drivers/of/Kconfig b/drivers/of/Kconfig
index 3a7a11a..e14dbe3 100644
--- a/drivers/of/Kconfig
+++ b/drivers/of/Kconfig
@@ -3,6 +3,7 @@ config OF_DEVICE
        depends on OF && (SPARC || PPC_OF)

 config OF_GPIO
+       select GENERIC_GPIO
        def_bool y
        depends on OF && PPC_OF && HAVE_GPIO_LIB
        help


-- 
Jon Smirl
jonsmirl@gmail.com

Re: Getting GPIO to build again

[Grant Likely]

On Wed, Jul 23, 2008 at 11:09:59PM -0400, Jon Smirl wrote:
> I just synced up to linus/master....

There is a fix for this in my tree for the 5200, but ben/paulus haven't
pulled it yet.

g.

> 
>   CC      arch/powerpc/platforms/52xx/mpc52xx_gpio.o
> In file included from arch/powerpc/platforms/52xx/mpc52xx_gpio.c:22:
> include/linux/of_gpio.h:26: error: field 'gc' has incomplete type
> include/linux/of_gpio.h: In function 'to_of_gpio_chip':
> include/linux/of_gpio.h:34: warning: type defaults to 'int' in
> declaration of '__mptr'
> include/linux/of_gpio.h:34: warning: initialization from incompatible
> pointer type
> In file included from include/asm/gpio.h:18,
>                  from arch/powerpc/platforms/52xx/mpc52xx_gpio.c:26:
> include/asm-generic/gpio.h: At top level:
> include/asm-generic/gpio.h:24: error: redefinition of 'gpio_is_valid'
> include/linux/gpio.h:24: error: previous definition of 'gpio_is_valid' was here
> In file included from arch/powerpc/platforms/52xx/mpc52xx_gpio.c:26:
> include/asm/gpio.h:27: error: redefinition of 'gpio_get_value'
> include/linux/gpio.h:50: error: previous definition of 'gpio_get_value' was here
> include/asm/gpio.h:32: error: redefinition of 'gpio_set_value'
> include/linux/gpio.h:57: error: previous definition of 'gpio_set_value' was here
> include/asm/gpio.h:37: error: redefinition of 'gpio_cansleep'
> include/linux/gpio.h:63: error: previous definition of 'gpio_cansleep' was here
> include/asm/gpio.h:45: error: redefinition of 'gpio_to_irq'
> include/linux/gpio.h:83: error: previous definition of 'gpio_to_irq' was here
> include/asm/gpio.h:50: error: redefinition of 'irq_to_gpio'
> include/linux/gpio.h:90: error: previous definition of 'irq_to_gpio' was here
> make[2]: *** [arch/powerpc/platforms/52xx/mpc52xx_gpio.o] Error 1
> make[1]: *** [arch/powerpc/platforms/52xx] Error 2
> make: *** [arch/powerpc/platforms] Error 2
> 
> 
> -- 
> Jon Smirl
> jonsmirl@gmail.com
> _______________________________________________
> Linuxppc-dev mailing list
> Linuxppc-dev@ozlabs.org
> https://ozlabs.org/mailman/listinfo/linuxppc-dev

Re: Getting GPIO to build again

[Anton Vorontsov]

On Wed, Jul 23, 2008 at 11:34:28PM -0400, Jon Smirl wrote:
> This lets me build again, no clue if it is the correct fix.

No, I don't think that this is correct. OF_GPIO isn't GENERIC_GPIO
provider. GPIO controllers should select GENERIC_GPIO instead.

Though, with this patch:
http://lkml.org/lkml/2008/7/10/269

We'll only have to select ARCH_WANT_OPTIONAL_GPIOLIB. Maybe for whole
powerpc.

> diff --git a/drivers/of/Kconfig b/drivers/of/Kconfig
> index 3a7a11a..e14dbe3 100644
> --- a/drivers/of/Kconfig
> +++ b/drivers/of/Kconfig
> @@ -3,6 +3,7 @@ config OF_DEVICE
>         depends on OF && (SPARC || PPC_OF)
> 
>  config OF_GPIO
> +       select GENERIC_GPIO
>         def_bool y
>         depends on OF && PPC_OF && HAVE_GPIO_LIB
>         help
> 

-- 
Anton Vorontsov
email: cbouatmailru@gmail.com
irc://irc.freenode.net/bd2

Re: Getting GPIO to build again

[Jochen Friedrich]

Hi Anton,

> Though, with this patch:
> http://lkml.org/lkml/2008/7/10/269
> 
> We'll only have to select ARCH_WANT_OPTIONAL_GPIOLIB. Maybe for whole
> powerpc.

That would simplify the GPIO support patches for CPM1/2, as well.

Thanks,
Jochen