Re: [PATCH 2/2] Update Poodle to current ASoC API

Re: [PATCH 2/2] Update Poodle to current ASoC API

[Mark Brown]

On Thu, Jul 24, 2008 at 04:54:48PM +0400, Dmitry Baryshkov wrote:
> Signed-off-by: Dmitry Baryshkov <dbaryshkov@gmail.com>
> Cc: Richard Purdie <rpurdie@rpsys.net>
> Cc: Mark Brown <broonie@opensource.wolfsonmicro.com>
> ---
>  This should probably go into 2.6.27, if possible

I've queued this for Takashi, thanks (he's on holiday this week).  I
had thought that at least the second hunk was already fixed but it seems
not.

Please CC all ALSA patches to alsa-devel@alsa-project.org.

Re: [PATCH 2/2] Update Poodle to current ASoC API

[Dmitry Baryshkov]

On Thu, Jul 24, 2008 at 02:10:21PM +0100, Mark Brown wrote:
> On Thu, Jul 24, 2008 at 04:54:48PM +0400, Dmitry Baryshkov wrote:
> > Signed-off-by: Dmitry Baryshkov <dbaryshkov@gmail.com>
> > Cc: Richard Purdie <rpurdie@rpsys.net>
> > Cc: Mark Brown <broonie@opensource.wolfsonmicro.com>
> > ---
> >  This should probably go into 2.6.27, if possible
> 
> I've queued this for Takashi, thanks (he's on holiday this week).  I
> had thought that at least the second hunk was already fixed but it seems
> not.

Actually the driver will still be broken w/o first patch. I hope that it
will be abe get in via Russell's tree.

> 
> Please CC all ALSA patches to alsa-devel@alsa-project.org.

This does collide with "don't cc lists if sending to LAKML" :)

-- 
With best wishes
Dmitry

Re: [PATCH 2/2] Update Poodle to current ASoC API

[Mark Brown]

On Thu, Jul 24, 2008 at 05:13:43PM +0400, Dmitry Baryshkov wrote:

> Actually the driver will still be broken w/o first patch. I hope that it
> will be abe get in via Russell's tree.

Right, but the patches are totally independant of each other so they may
as well go via the relevant subsystem trees.

Re: [PATCH 2/2] Update Poodle to current ASoC API

[Eric Miao]

Mark Brown wrote:
> On Thu, Jul 24, 2008 at 04:54:48PM +0400, Dmitry Baryshkov wrote:
>> Signed-off-by: Dmitry Baryshkov <dbaryshkov@gmail.com>
>> Cc: Richard Purdie <rpurdie@rpsys.net>
>> Cc: Mark Brown <broonie@opensource.wolfsonmicro.com>
>> ---
>>  This should probably go into 2.6.27, if possible
> 
> I've queued this for Takashi, thanks (he's on holiday this week).  I
> had thought that at least the second hunk was already fixed but it seems
> not.
> 

This probably should go through the arm tree, along with other
poodle patches, otherwise it just creates headache for Russell
in the next merge.

As if should go into 2.6.27, I don't know. Depending on if it
qualifies to be a fix or just a clean-up, from ALSA's point of
view.

> Please CC all ALSA patches to alsa-devel@alsa-project.org.
> 
> -------------------------------------------------------------------
> List admin: http://lists.arm.linux.org.uk/mailman/listinfo/linux-arm-kernel
> FAQ:        http://www.arm.linux.org.uk/mailinglists/faq.php
> Etiquette:  http://www.arm.linux.org.uk/mailinglists/etiquette.php

Re: [PATCH 2/2] Update Poodle to current ASoC API

[Dmitry Baryshkov]

On Thu, Jul 24, 2008 at 09:38:19PM +0800, Eric Miao wrote:
> Mark Brown wrote:
> > On Thu, Jul 24, 2008 at 04:54:48PM +0400, Dmitry Baryshkov wrote:
> >> Signed-off-by: Dmitry Baryshkov <dbaryshkov@gmail.com>
> >> Cc: Richard Purdie <rpurdie@rpsys.net>
> >> Cc: Mark Brown <broonie@opensource.wolfsonmicro.com>
> >> ---
> >>  This should probably go into 2.6.27, if possible
> > 
> > I've queued this for Takashi, thanks (he's on holiday this week).  I
> > had thought that at least the second hunk was already fixed but it seems
> > not.
> > 
> 
> This probably should go through the arm tree, along with other
> poodle patches, otherwise it just creates headache for Russell
> in the next merge.
> 
> As if should go into 2.6.27, I don't know. Depending on if it
> qualifies to be a fix or just a clean-up, from ALSA's point of
> view.

Currently SND_PXA2XX_SOC_POODLE is broken. However IIUC it's broken
since it was added in 2006, so no hurry probably.

> 
> > Please CC all ALSA patches to alsa-devel@alsa-project.org.
> > 
> > -------------------------------------------------------------------
> > List admin: http://lists.arm.linux.org.uk/mailman/listinfo/linux-arm-kernel
> > FAQ:        http://www.arm.linux.org.uk/mailinglists/faq.php
> > Etiquette:  http://www.arm.linux.org.uk/mailinglists/etiquette.php
> 

-- 
With best wishes
Dmitry

Re: [PATCH 2/2] Update Poodle to current ASoC API

[Mark Brown]

On Thu, Jul 24, 2008 at 09:38:19PM +0800, Eric Miao wrote:
> Mark Brown wrote:

> > I've queued this for Takashi, thanks (he's on holiday this week).  I
> > had thought that at least the second hunk was already fixed but it seems
> > not.

> This probably should go through the arm tree, along with other
> poodle patches, otherwise it just creates headache for Russell
> in the next merge.

Avoiding headaches for Russell was part of the goal here - ASoC is
currently undergoing some fairly invasive renovations which increase the
chances of conflicts being introduced with changes done to sound/soc
outside that.

This patch is in sound/soc only so it can't directly conflict with the
arch/arm changes that Russell is or will be carrying.

> As if should go into 2.6.27, I don't know. Depending on if it
> qualifies to be a fix or just a clean-up, from ALSA's point of
> view.

Currently it fails to build, partially fixed by this patch, so it's
not just coding style.

Re: [PATCH 2/2] Update Poodle to current ASoC API

[Eric Miao]

Mark Brown wrote:
> On Thu, Jul 24, 2008 at 09:38:19PM +0800, Eric Miao wrote:
>> Mark Brown wrote:
> 
>>> I've queued this for Takashi, thanks (he's on holiday this week).  I
>>> had thought that at least the second hunk was already fixed but it seems
>>> not.
> 
>> This probably should go through the arm tree, along with other
>> poodle patches, otherwise it just creates headache for Russell
>> in the next merge.
> 
> Avoiding headaches for Russell was part of the goal here - ASoC is
> currently undergoing some fairly invasive renovations which increase the
> chances of conflicts being introduced with changes done to sound/soc
> outside that.
> 
> This patch is in sound/soc only so it can't directly conflict with the
> arch/arm changes that Russell is or will be carrying.
> 

Oh, I've mistaken it with the poodle.c in arch/arm/mach-pxa.

>> As if should go into 2.6.27, I don't know. Depending on if it
>> qualifies to be a fix or just a clean-up, from ALSA's point of
>> view.
> 
> Currently it fails to build, partially fixed by this patch, so it's
> not just coding style.

Right, and I was just wondering why those "snd_*_t" still exists.