From: Christian Franke <Christian.Franke@t-online.de>
To: The development of GRUB 2 <grub-devel@gnu.org>
Subject: Re: Remove conf/*.mk from svn
Date: Fri, 25 Jul 2008 20:41:00 +0200 [thread overview]
Message-ID: <488A1E3C.7030108@t-online.de> (raw)
In-Reply-To: <20080725081827.42534c83@gibibit.com>
Colin D Bennett wrote:
> On Thu, 24 Jul 2008 22:17:06 -0700 (PDT)
> Viswesh S <...> wrote:
>
>
>> I have modified the conf/common.mk accordingly as shown below.
>>
>
> GRUB developers,
>
> I think we should remove conf/*.mk from the Subversion repository. If
> people are going to be developing on GRUB and checking out svn
> branches, then I think it's fine to require them to have Ruby. For
> released tarballs that we expect non-developers to use, we just need to
> generate the *.mk files and include them in the tarball.
>
> What is the benefit of having conf/*.mk files in svn? They cause lots
> of merge conflicts: sure, the conflicts are easy to resolve by simply
> choosing to take one of the revisions, but then that merge really has
> not meaning, since it won't be in sync with your .rmk file until it's
> once again regenerated and checked in.
>
> Removing the autogenerated .mk files would also eliminate problems new
> developers like Viswesh and I have encountered -- we won't be tempted
> to modify a non-versioned file like this.
>
>
I agree, the files generated by ./autogen.sh should be included in
tarball, but not in the repo.
Additional prerequisites (autoconf, ruby) for builds from svn are IMO OK.
In my local grub2 git repo, these files are excluded:
configure
config.h.in
stamp-h.in
conf/*.mk
BTW: autogen.sh should "touch stamp-h.in" to be consistent with the
Makefile rule for config.h.in.
Christian
next prev parent reply other threads:[~2008-07-25 18:41 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-25 5:17 Linking Viswesh S
2008-07-25 5:35 ` Linking Pavel Roskin
2008-07-25 15:18 ` Remove conf/*.mk from svn (was: Re: Linking) Colin D Bennett
2008-07-25 18:41 ` Christian Franke [this message]
2008-07-27 7:17 ` Remove conf/*.mk from svn Pavel Roskin
2008-07-27 22:28 ` Christian Franke
2008-07-28 22:43 ` Pavel Roskin
2008-08-05 10:38 ` Marco Gerards
2008-07-25 20:43 ` Remove conf/*.mk from svn (was: Re: Linking) Robert Millan
2008-07-31 20:18 ` Yoshinori K. Okuji
2008-08-05 10:40 ` Remove conf/*.mk from svn Marco Gerards
2008-08-05 15:38 ` Vesa Jääskeläinen
2008-08-05 15:48 ` Marco Gerards
2008-08-05 12:02 ` Seeking for the start administrador02032
2008-08-05 15:55 ` Remove conf/*.mk from svn Felix Zielcke
2008-08-05 18:41 ` Javier Martín
2008-08-05 18:51 ` Colin D Bennett
-- strict thread matches above, loose matches on Subject: below --
2008-08-06 4:58 Viswesh S
2008-08-06 14:56 ` Vesa Jääskeläinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=488A1E3C.7030108@t-online.de \
--to=christian.franke@t-online.de \
--cc=grub-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.