* isdn/eicon: msg_in_{wrap,read}_pos assigned twice?
@ 2008-07-25 19:26 roel kluin
2008-07-28 14:41 ` Armin Schindler
0 siblings, 1 reply; 2+ messages in thread
From: roel kluin @ 2008-07-25 19:26 UTC (permalink / raw)
To: mac; +Cc: linux-kernel
vi drivers/isdn/hardware/eicon/message.c +4035
and note two similar tests on line 4035 and 4049:
[else] if (plci->msg_in_read_pos == plci->msg_in_wrap_pos)
after the first test:
plci->msg_in_wrap_pos = MSG_IN_QUEUE_SIZE;
plci->msg_in_read_pos = i + MSG_IN_OVERHEAD;
but then after the second test as well:
plci->msg_in_read_pos = MSG_IN_QUEUE_SIZE;
plci->msg_in_wrap_pos = MSG_IN_QUEUE_SIZE;
So the assignment after the first test has no effect. Is this a bug?
Roel Kluin
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: isdn/eicon: msg_in_{wrap,read}_pos assigned twice?
2008-07-25 19:26 isdn/eicon: msg_in_{wrap,read}_pos assigned twice? roel kluin
@ 2008-07-28 14:41 ` Armin Schindler
0 siblings, 0 replies; 2+ messages in thread
From: Armin Schindler @ 2008-07-28 14:41 UTC (permalink / raw)
To: roel kluin; +Cc: linux-kernel
On Fri, 25 Jul 2008, roel kluin wrote:
> vi drivers/isdn/hardware/eicon/message.c +4035
>
> and note two similar tests on line 4035 and 4049:
>
> [else] if (plci->msg_in_read_pos == plci->msg_in_wrap_pos)
>
> after the first test:
>
> plci->msg_in_wrap_pos = MSG_IN_QUEUE_SIZE;
> plci->msg_in_read_pos = i + MSG_IN_OVERHEAD;
>
> but then after the second test as well:
>
> plci->msg_in_read_pos = MSG_IN_QUEUE_SIZE;
> plci->msg_in_wrap_pos = MSG_IN_QUEUE_SIZE;
>
>
> So the assignment after the first test has no effect. Is this a bug?
If (plci->msg_in_read_pos == plci->msg_in_wrap_pos) is true in the first
test it can't be true in the second.
So the code could be optimized a bit. But the first assignments are needed.
If it's false in the first it may become true in the second. So it's not a
bug. All conditions are really needed.
Armin
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2008-07-28 15:06 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-07-25 19:26 isdn/eicon: msg_in_{wrap,read}_pos assigned twice? roel kluin
2008-07-28 14:41 ` Armin Schindler
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.