From: Avi Kivity <avi@qumranet.com>
To: Julia Lawall <julia@diku.dk>
Cc: kvm@vger.kernel.org, xiantao.zhang@intel.com,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH retry] arch/ia64/kvm/kvm-ia64.c: Add local_irq_restore
Date: Sat, 26 Jul 2008 09:10:01 +0000 [thread overview]
Message-ID: <488AE9E9.1020502@qumranet.com> (raw)
In-Reply-To: <Pine.LNX.4.64.0807222137350.2670@ask.diku.dk>
Julia Lawall wrote:
> From: Julia Lawall <julia@diku.dk>
>
> There is a call to local_irq_restore in the normal exit case, so it would
> seem that there should be one on an error return as well.
>
> The semantic patch that finds this problem is as follows:
> (http://www.emn.fr/x-info/coccinelle/)
>
Applied, thanks.
--
Do not meddle in the internals of kernels, for they are subtle and quick to panic.
WARNING: multiple messages have this Message-ID (diff)
From: Avi Kivity <avi@qumranet.com>
To: Julia Lawall <julia@diku.dk>
Cc: kvm@vger.kernel.org, xiantao.zhang@intel.com,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH retry] arch/ia64/kvm/kvm-ia64.c: Add local_irq_restore in error handling code
Date: Sat, 26 Jul 2008 12:10:01 +0300 [thread overview]
Message-ID: <488AE9E9.1020502@qumranet.com> (raw)
In-Reply-To: <Pine.LNX.4.64.0807222137350.2670@ask.diku.dk>
Julia Lawall wrote:
> From: Julia Lawall <julia@diku.dk>
>
> There is a call to local_irq_restore in the normal exit case, so it would
> seem that there should be one on an error return as well.
>
> The semantic patch that finds this problem is as follows:
> (http://www.emn.fr/x-info/coccinelle/)
>
Applied, thanks.
--
Do not meddle in the internals of kernels, for they are subtle and quick to panic.
next prev parent reply other threads:[~2008-07-26 9:10 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-22 19:38 [PATCH retry] arch/ia64/kvm/kvm-ia64.c: Add local_irq_restore in Julia Lawall
2008-07-22 19:38 ` [PATCH retry] arch/ia64/kvm/kvm-ia64.c: Add local_irq_restore in error handling code Julia Lawall
2008-07-22 19:53 ` Matthew Wilcox
2008-07-22 19:53 ` Matthew Wilcox
2008-07-23 1:26 ` Zhang, Xiantao
2008-07-23 1:26 ` Zhang, Xiantao
2008-07-24 11:35 ` [PATCH retry] arch/ia64/kvm/kvm-ia64.c: Add local_irq_restore walter harms
2008-07-24 12:27 ` Julia Lawall
2008-07-26 9:10 ` Avi Kivity [this message]
2008-07-26 9:10 ` [PATCH retry] arch/ia64/kvm/kvm-ia64.c: Add local_irq_restore in error handling code Avi Kivity
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=488AE9E9.1020502@qumranet.com \
--to=avi@qumranet.com \
--cc=julia@diku.dk \
--cc=kernel-janitors@vger.kernel.org \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=xiantao.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.