All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] kvm: ppc: qemu: Fix 440 CPU initialization
@ 2008-07-23 20:30 Hollis Blanchard
  2008-07-27 10:09 ` Avi Kivity
  0 siblings, 1 reply; 2+ messages in thread
From: Hollis Blanchard @ 2008-07-23 20:30 UTC (permalink / raw)
  To: kvm-ppc

# HG changeset patch
# User Hollis Blanchard <hollisb@us.ibm.com>
# Date 1216845007 18000
# Node ID 40d8ba7ccef06cdb99af00a28825c4c80bb3dbf6
# Parent  b1d0e9c44b7ce0ca8035582ab791a451eec141ca
kvm: ppc: qemu: Fix 440 CPU initialization

Qemu doesn't implement 440 emulation, so pretend we're 405 instead. (We used
to provide our own cpu_ppc_find_by_name() function that allowed us to use
"440".)

This fixes a fatal runtime error introduced in a recent upstream qemu merge.

Signed-off-by: Hollis Blanchard <hollisb@us.ibm.com>

diff --git a/qemu/hw/ppc440_bamboo.c b/qemu/hw/ppc440_bamboo.c
--- a/qemu/hw/ppc440_bamboo.c
+++ b/qemu/hw/ppc440_bamboo.c
@@ -77,10 +77,12 @@ void bamboo_init(ram_addr_t ram_size, in
 		mem_reg_property[2] = ram_size;
 	}
 
-	/* Setup CPU */
-	env = cpu_ppc_init("440");
+	/* Setup CPU.
+	 * XXX Since qemu doesn't implement 440, we just say it's a 405. Since
+	 * we don't use qemu's CPU emulation it seems to be working OK. */
+	env = cpu_ppc_init("405");
 	if (!env) {
-		fprintf(stderr, "Unable to initilize CPU!\n");
+		fprintf(stderr, "Unable to initialize CPU!\n");
 		exit(1);
 	}
 

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] kvm: ppc: qemu: Fix 440 CPU initialization
  2008-07-23 20:30 [PATCH] kvm: ppc: qemu: Fix 440 CPU initialization Hollis Blanchard
@ 2008-07-27 10:09 ` Avi Kivity
  0 siblings, 0 replies; 2+ messages in thread
From: Avi Kivity @ 2008-07-27 10:09 UTC (permalink / raw)
  To: kvm-ppc

Hollis Blanchard wrote:
> Qemu doesn't implement 440 emulation, so pretend we're 405 instead. (We used
> to provide our own cpu_ppc_find_by_name() function that allowed us to use
> "440".)
>
> This fixes a fatal runtime error introduced in a recent upstream qemu merge.
>
>   

Applied, thanks.

-- 
error compiling committee.c: too many arguments to function


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2008-07-27 10:09 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-07-23 20:30 [PATCH] kvm: ppc: qemu: Fix 440 CPU initialization Hollis Blanchard
2008-07-27 10:09 ` Avi Kivity

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.