From: Jeremy Fitzhardinge <jeremy@goop.org>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: righi.andrea@gmail.com, kosaki.motohiro@jp.fujitsu.com,
torvalds@linux-foundation.org, linux-mm@kvack.org,
linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org,
Ingo Molnar <mingo@elte.hu>, Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [PATCH 1/1] mm: unify pmd_free() implementation
Date: Mon, 28 Jul 2008 13:46:24 -0700 [thread overview]
Message-ID: <488E3020.1040701@goop.org> (raw)
In-Reply-To: <20080728133030.8b29fa5a.akpm@linux-foundation.org>
Andrew Morton wrote:
> I can second that. See
> http://userweb.kernel.org/~akpm/mmotm/broken-out/include-asm-generic-pgtable-nopmdh-macros-are-noxious-reason-435.patch
>
> Ingo cruelly ignored it. Probably he's used to ignoring the comit
> storm which I send in his direction - I'll need to resend it sometime.
>
> I'd consider that patch to be partial - we should demacroize the
> surrounding similar functions too. But that will require a bit more
> testing.
Its immediate neighbours should be easy enough (pmd_alloc_one,
__pmd_free_tlb), but any of the ones involving pmd_t risk #include hell
(though the earlier references to pud_t in inline functions suggest it
will work). And pmd_addr_end is just ugly.
J
WARNING: multiple messages have this Message-ID (diff)
From: Jeremy Fitzhardinge <jeremy@goop.org>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: righi.andrea@gmail.com, kosaki.motohiro@jp.fujitsu.com,
torvalds@linux-foundation.org, linux-mm@kvack.org,
linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org,
Ingo Molnar <mingo@elte.hu>, Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [PATCH 1/1] mm: unify pmd_free() implementation
Date: Mon, 28 Jul 2008 13:46:24 -0700 [thread overview]
Message-ID: <488E3020.1040701@goop.org> (raw)
In-Reply-To: <20080728133030.8b29fa5a.akpm@linux-foundation.org>
Andrew Morton wrote:
> I can second that. See
> http://userweb.kernel.org/~akpm/mmotm/broken-out/include-asm-generic-pgtable-nopmdh-macros-are-noxious-reason-435.patch
>
> Ingo cruelly ignored it. Probably he's used to ignoring the comit
> storm which I send in his direction - I'll need to resend it sometime.
>
> I'd consider that patch to be partial - we should demacroize the
> surrounding similar functions too. But that will require a bit more
> testing.
Its immediate neighbours should be easy enough (pmd_alloc_one,
__pmd_free_tlb), but any of the ones involving pmd_t risk #include hell
(though the earlier references to pud_t in inline functions suggest it
will work). And pmd_addr_end is just ugly.
J
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2008-07-28 20:46 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-28 15:51 [PATCH 1/1] mm: unify pmd_free() implementation Andrea Righi
2008-07-28 15:51 ` Andrea Righi
2008-07-28 15:53 ` Linus Torvalds
2008-07-28 15:53 ` Linus Torvalds
2008-07-28 16:17 ` Andrea Righi
2008-07-28 16:17 ` Andrea Righi
2008-07-28 16:27 ` KOSAKI Motohiro
2008-07-28 16:27 ` KOSAKI Motohiro
2008-07-28 17:19 ` Andrea Righi
2008-07-28 17:19 ` Andrea Righi
2008-07-28 20:30 ` Andrew Morton
2008-07-28 20:30 ` Andrew Morton
2008-07-28 20:46 ` Jeremy Fitzhardinge [this message]
2008-07-28 20:46 ` Jeremy Fitzhardinge
2008-07-28 22:53 ` [PATCH 1/1] mm: unify pmd_free() and __pmd_free_tlb() implementation Andrea Righi
2008-07-28 22:53 ` Andrea Righi
2008-07-31 16:17 ` Ingo Molnar
2008-07-31 16:17 ` Ingo Molnar
2008-07-31 16:59 ` Andrea Righi
2008-07-31 16:59 ` Andrea Righi
2008-07-28 16:17 ` [PATCH 1/1] mm: unify pmd_free() implementation James Bottomley
2008-07-28 16:17 ` James Bottomley
2008-07-28 16:45 ` Linus Torvalds
2008-07-28 16:45 ` Linus Torvalds
2008-07-28 16:58 ` James Bottomley
2008-07-28 16:58 ` James Bottomley
2008-07-28 17:10 ` Linus Torvalds
2008-07-28 17:10 ` Linus Torvalds
2008-07-28 20:08 ` [PATCH 1/1] mm: unify pmd_free() implementation -> instrumentation Mathieu Desnoyers
2008-07-28 20:08 ` Mathieu Desnoyers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=488E3020.1040701@goop.org \
--to=jeremy@goop.org \
--cc=akpm@linux-foundation.org \
--cc=kosaki.motohiro@jp.fujitsu.com \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mingo@elte.hu \
--cc=righi.andrea@gmail.com \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.