All of lore.kernel.org
 help / color / mirror / Atom feed
* A possible typo defining MAX_INT in reiserfs_fs.h ?
@ 2008-07-30  7:26 Colin Ian King
  2008-07-30  8:37 ` Edward Shishkin
  0 siblings, 1 reply; 3+ messages in thread
From: Colin Ian King @ 2008-07-30  7:26 UTC (permalink / raw)
  To: reiserfs-devel; +Cc: chris.mason

Hi there,

This is a very quick question about a possible typo:

In include/linux/reiserfs_fs.h

there are the lines:

#define MAX_UL_INT 0xffffffff
#define MAX_INT 0x7ffffff

Should MAX_INT should be "0x7fffffff" rather than "0x7ffffff"?

Thanks for any clarification,

Colin King. 




^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: A possible typo defining MAX_INT in reiserfs_fs.h ?
  2008-07-30  7:26 A possible typo defining MAX_INT in reiserfs_fs.h ? Colin Ian King
@ 2008-07-30  8:37 ` Edward Shishkin
  2008-07-30 12:39   ` Chris Mason
  0 siblings, 1 reply; 3+ messages in thread
From: Edward Shishkin @ 2008-07-30  8:37 UTC (permalink / raw)
  To: Colin Ian King; +Cc: reiserfs-devel, chris.mason

Colin Ian King wrote:
> Hi there,
>
> This is a very quick question about a possible typo:
>
> In include/linux/reiserfs_fs.h
>
> there are the lines:
>
> #define MAX_UL_INT 0xffffffff
> #define MAX_INT 0x7ffffff
>   
^^^^^^^^^^^^^^^^^^^^^^^^^^^
> Should MAX_INT should be "0x7fffffff" rather than "0x7ffffff"?
>
> Thanks for any clarification,
>   

I would suggest a version that this line is unused garbage.
Any opinions?

Thanks,
Edward.

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: A possible typo defining MAX_INT in reiserfs_fs.h ?
  2008-07-30  8:37 ` Edward Shishkin
@ 2008-07-30 12:39   ` Chris Mason
  0 siblings, 0 replies; 3+ messages in thread
From: Chris Mason @ 2008-07-30 12:39 UTC (permalink / raw)
  To: Edward Shishkin; +Cc: Colin Ian King, reiserfs-devel

On Wed, 2008-07-30 at 12:37 +0400, Edward Shishkin wrote:
> Colin Ian King wrote:
> > Hi there,
> >
> > This is a very quick question about a possible typo:
> >
> > In include/linux/reiserfs_fs.h
> >
> > there are the lines:
> >
> > #define MAX_UL_INT 0xffffffff
> > #define MAX_INT 0x7ffffff
> >   
> ^^^^^^^^^^^^^^^^^^^^^^^^^^^
> > Should MAX_INT should be "0x7fffffff" rather than "0x7ffffff"?
> >
> > Thanks for any clarification,
> >   
> 
> I would suggest a version that this line is unused garbage.
> Any opinions?

Seems unused in fs/reiserfs/* and include/linux/reiserfs*

-chris



^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2008-07-30 12:39 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-07-30  7:26 A possible typo defining MAX_INT in reiserfs_fs.h ? Colin Ian King
2008-07-30  8:37 ` Edward Shishkin
2008-07-30 12:39   ` Chris Mason

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.