A small portability issue introduced by changeset 17951

A small portability issue introduced by changeset 17951

[Cui, Dexuan]

changeset 17951: e65fe28b5288 uses a shell command "lspci -vmmD".
But the "-D" parameter is not supported in relatively-old version of
pciutils, like pciutils-2.1.99.test8-3.4 (for instance, this vresion can
be found in RHEL4u6).
It'd be nice to have it fixed.
 
Thanks,
-- Dexuan

 

Re: A small portability issue introduced by changeset 17951

[Yosuke Iwamatsu]

[-- Attachment #1: Type: text/plain, Size: 502 bytes --]

Hi,

Cui, Dexuan wrote:
> changeset 17951: e65fe28b5288 uses a shell command "lspci -vmmD".
> But the "-D" parameter is not supported in relatively-old version of
> pciutils, like pciutils-2.1.99.test8-3.4 (for instance, this vresion can
> be found in RHEL4u6).
> It'd be nice to have it fixed.

The attached patch uses 'lspci -vmm' instead of '-vmmD'.
The pci domain number may be omitted from the output of lspci, but
pci_parse_name() will set it default to 0 if it doesn't exist.

Thanks,
-- Yosuke

[-- Attachment #2: lspci_parse.patch --]
[-- Type: all/allfiles, Size: 2045 bytes --]

[-- Attachment #3: Type: text/plain, Size: 138 bytes --]

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel