All of lore.kernel.org
 help / color / mirror / Atom feed
From: Anthony Liguori <anthony@codemonkey.ws>
To: "Daniel P. Berrange" <berrange@redhat.com>, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] PATCH: v3 Allow control over drive file open mode
Date: Fri, 01 Aug 2008 10:10:09 -0500	[thread overview]
Message-ID: <48932751.5040303@codemonkey.ws> (raw)
In-Reply-To: <20080801102949.GN23993@redhat.com>

Daniel P. Berrange wrote:
> This is version 3 of the patch.
>   

Allowing the user to specify what mode we use to open a file is IMHO not 
a good interface for a user.  A user should only be concerned with how 
we expose a disk to the guest, not the underlying implementation of how 
we support this.  It has subtle side-effects that a user is not going to 
expect unless they are intimately familiar with how QEMU is implemented 
(like snapshotting breaking).

Regards,

Anthony Liguori

  reply	other threads:[~2008-08-01 15:10 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-08-01 10:29 [Qemu-devel] PATCH: v3 Allow control over drive file open mode Daniel P. Berrange
2008-08-01 15:10 ` Anthony Liguori [this message]
2008-08-01 16:15   ` Daniel P. Berrange
2008-08-01 16:23     ` Andreas Färber
2008-08-01 17:06     ` Jamie Lokier
2008-08-01 16:57   ` Ian Jackson
2008-08-01 17:14     ` Anthony Liguori
2008-08-01 17:27       ` Jamie Lokier
2008-08-11 16:05       ` Ian Jackson
2008-08-12 11:42         ` Kevin Wolf
2008-08-12 13:31         ` Anthony Liguori
2008-08-12 23:56           ` Jamie Lokier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=48932751.5040303@codemonkey.ws \
    --to=anthony@codemonkey.ws \
    --cc=berrange@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.