All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kevin Wolf <kwolf@suse.de>
To: Ian Jackson <Ian.Jackson@eu.citrix.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] PATCH: v3 Allow control over drive file open mode
Date: Tue, 12 Aug 2008 13:42:01 +0200	[thread overview]
Message-ID: <48A17709.50905@suse.de> (raw)
In-Reply-To: <18592.25422.257378.988970@mariner.uk.xensource.com>

Ian Jackson schrieb:
>> qemu-system-x86_64 -drive file=foo.img -drive file=boo.img,read-only=on
>>
>> Down the road, you do a savevm.  savevm has to create a checkpoint in 
>> all disk images.  The checkpoint will be empty in boo.img but it still 
>> needs to create one.
> 
> Perhaps I don't understand clearly enough how you imagine this
> scenario.  Surely when the snapshot is resumed it is sufficient for
> the file boo.img to be identical ?
> 
> What are these checkpoints ?  Are they currently written by anything ?
> 
> I've tried to look for the code you would be referring to but I can't
> seem to find it.  qemu_savevm_state just calls all the things recorded
> with register_savevm and I can't seem to find anything that would do
> anything to block drivers. 

This code is in do_savevm (in vl.c). Look for /* create the snapshots */

Kevin

  reply	other threads:[~2008-08-12 11:43 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-08-01 10:29 [Qemu-devel] PATCH: v3 Allow control over drive file open mode Daniel P. Berrange
2008-08-01 15:10 ` Anthony Liguori
2008-08-01 16:15   ` Daniel P. Berrange
2008-08-01 16:23     ` Andreas Färber
2008-08-01 17:06     ` Jamie Lokier
2008-08-01 16:57   ` Ian Jackson
2008-08-01 17:14     ` Anthony Liguori
2008-08-01 17:27       ` Jamie Lokier
2008-08-11 16:05       ` Ian Jackson
2008-08-12 11:42         ` Kevin Wolf [this message]
2008-08-12 13:31         ` Anthony Liguori
2008-08-12 23:56           ` Jamie Lokier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=48A17709.50905@suse.de \
    --to=kwolf@suse.de \
    --cc=Ian.Jackson@eu.citrix.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.