From: Tejun Heo <tj@kernel.org>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: "Bartlomiej Zolnierkiewicz" <bzolnier@gmail.com>,
"David Müller" <dave.mueller@gmx.ch>,
jgarzik@pobox.com, linux-ide@vger.kernel.org
Subject: Re: [PATCH] libata: fix out-of-bounds access in pata_oldpiix.c
Date: Sun, 03 Aug 2008 14:22:52 +0900 [thread overview]
Message-ID: <489540AC.9060409@kernel.org> (raw)
In-Reply-To: <20080801232914.3077c21b@lxorguk.ukuu.org.uk>
Alan Cox wrote:
>> see it as libata-core won't call them if unsupported but qc_issue will
>> see it. Can you please unnak?
>
> No. Please see the patch I posted. It got a bit stuck as I got no reply
> at all to the original query so it was filed on the low priority pile.
> Simply quick fixing one case isn't the way to sort a bug like that.
>
> No un-nak as I've now been through and fixed the lot including a couple
> of really nasty assumptions that >= UDMA_0 means UDMA mode (which isnt
> true as 0xFF is no DMA)
Ah... okay. That looks like a much better way to handle this. Let's
continue there. Thanks.
--
tejun
prev parent reply other threads:[~2008-08-03 5:23 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-18 7:06 [PATCH] libata: fix out-of-bounds access in pata_oldpiix.c David Müller
2008-07-18 8:55 ` Alan Cox
2008-07-18 14:15 ` Bartlomiej Zolnierkiewicz
2008-08-01 4:35 ` Tejun Heo
2008-08-01 22:29 ` Alan Cox
2008-08-03 5:22 ` Tejun Heo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=489540AC.9060409@kernel.org \
--to=tj@kernel.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=bzolnier@gmail.com \
--cc=dave.mueller@gmx.ch \
--cc=jgarzik@pobox.com \
--cc=linux-ide@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.