All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] Fix save of negated dscp match rules
@ 2008-08-03 15:31 Phil Oester
  2008-08-04 11:31 ` Patrick McHardy
  0 siblings, 1 reply; 2+ messages in thread
From: Phil Oester @ 2008-08-03 15:31 UTC (permalink / raw)
  To: netfilter-devel

[-- Attachment #1: Type: text/plain, Size: 199 bytes --]

As pointed out by Vyacheslav Garashchenko, iptables-save does not
save negated dscp matches properly.  Fix below.

This closes bugzilla #533.

Phil

Signed-off-by: Phil Oester <kernel@linuxace.com>


[-- Attachment #2: patch-dscp-save --]
[-- Type: text/plain, Size: 316 bytes --]

--- iptables/extensions/libxt_dscp.c	2008-06-24 13:58:46.000000000 -0700
+++ iptables-1.4.1.1/extensions/libxt_dscp.c	2008-08-03 08:26:36.000000000 -0700
@@ -119,7 +119,7 @@
 print_dscp(u_int8_t dscp, int invert, int numeric)
 {
 	if (invert)
-		fputc('!', stdout);
+		printf("! ");
 
  	printf("0x%02x ", dscp);
 }

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] Fix save of negated dscp match rules
  2008-08-03 15:31 [PATCH] Fix save of negated dscp match rules Phil Oester
@ 2008-08-04 11:31 ` Patrick McHardy
  0 siblings, 0 replies; 2+ messages in thread
From: Patrick McHardy @ 2008-08-04 11:31 UTC (permalink / raw)
  To: Phil Oester; +Cc: netfilter-devel

Phil Oester wrote:
> As pointed out by Vyacheslav Garashchenko, iptables-save does not
> save negated dscp matches properly.  Fix below.
> 
> This closes bugzilla #533.

Applied, thanks.

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2008-08-04 11:31 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-08-03 15:31 [PATCH] Fix save of negated dscp match rules Phil Oester
2008-08-04 11:31 ` Patrick McHardy

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.