Re: [PATCH] new code cleanups

Re: [PATCH] new code cleanups

[Dushan Tcholich]

Hi
Have these mails passed to m-l? I can't see these mails in archives,
but I haven't recieved the rejected mail notifications too.
Mail me if you need patches sent some other way.

Thanks
Dushan

On Wed, Aug 6, 2008 at 3:34 PM, Dushan Tcholich <dusanc@gmail.com> wrote:
> Hello
> I've made more cleanups ontop of the patch from yesterday.
> This new patch removes around 1200 errors and 40 warnings reported by
> checkpatch-0.21
> Errors removed are: ERROR: "foo * bar" should be "foo *bar"
> Warnings removed are from extra spaces around parenthesis.
> Patch was compile tested against 2.6.27-rc1-mm1+newcodecleanups.patch
>
> I hope this helps
>
> Have a nice day
> Dushan
>
> PS. patch is about 400kB so i had to compress it
>
> On Tue, Aug 5, 2008 at 2:54 PM, Dushan Tcholich <dusanc@gmail.com> wrote:
>> Hello
>>
>> While running checkpatch on newest r4 in -mm kernels I noticed that I
>> already did some cleanups that were reported.
>> Then I realised that one patch that I sent that removed about
>> 300errors and 500 warnings was misplaced in that patchstorm :) and not
>> sent to akpm.
>> Here it is again rebased on 2.6.27-rc1-mm1, compile tested.
>> Please review
>>
>> Thanks for your time
>> Dushan
>>
>

Re: [PATCH] new code cleanups

[Edward Shishkin]

Dushan Tcholich wrote:
> Hi
> Have these mails passed to m-l?

Yes.
Thanks!

>  I can't see these mails in archives,
> but I haven't recieved the rejected mail notifications too.
> Mail me if you need patches sent some other way.
>
> Thanks
> Dushan
>
> On Wed, Aug 6, 2008 at 3:34 PM, Dushan Tcholich <dusanc@gmail.com> wrote:
>   
>> Hello
>> I've made more cleanups ontop of the patch from yesterday.
>> This new patch removes around 1200 errors and 40 warnings reported by
>> checkpatch-0.21
>> Errors removed are: ERROR: "foo * bar" should be "foo *bar"
>> Warnings removed are from extra spaces around parenthesis.
>> Patch was compile tested against 2.6.27-rc1-mm1+newcodecleanups.patch
>>
>> I hope this helps
>>
>> Have a nice day
>> Dushan
>>
>> PS. patch is about 400kB so i had to compress it
>>
>> On Tue, Aug 5, 2008 at 2:54 PM, Dushan Tcholich <dusanc@gmail.com> wrote:
>>     
>>> Hello
>>>
>>> While running checkpatch on newest r4 in -mm kernels I noticed that I
>>> already did some cleanups that were reported.
>>> Then I realised that one patch that I sent that removed about
>>> 300errors and 500 warnings was misplaced in that patchstorm :) and not
>>> sent to akpm.
>>> Here it is again rebased on 2.6.27-rc1-mm1, compile tested.
>>> Please review
>>>
>>> Thanks for your time
>>> Dushan
>>>
>>>       
>
>   

Re: [PATCH] new code cleanups

[Dushan Tcholich]

[-- Attachment #1: Type: text/plain, Size: 1870 bytes --]

Hello

As I saw while doing this that there are only about 1200 errors left I
was stubborn enough to continue cleaning.
So here's the newest patch, probably last one, which shaves off
another ~1000 errors reported by checkpatch.
It's the 3'rd in series, so it's based on
2.6.27-rc1-mm1+newcleanups+newcleanups1.
It's compile tested ofcourse and compressed because it's ~275kB.

I hope this helped

Have fun
Dushan

On Wed, Aug 6, 2008 at 8:15 PM, Edward Shishkin
<edward.shishkin@gmail.com> wrote:
> Dushan Tcholich wrote:
>> Hi
>> Have these mails passed to m-l?
>
> Yes.
> Thanks!
>
>>  I can't see these mails in archives,
>> but I haven't recieved the rejected mail notifications too.
>> Mail me if you need patches sent some other way.
>>
>> Thanks
>> Dushan
>>
>> On Wed, Aug 6, 2008 at 3:34 PM, Dushan Tcholich <dusanc@gmail.com> wrote:
>>
>>> Hello
>>> I've made more cleanups ontop of the patch from yesterday.
>>> This new patch removes around 1200 errors and 40 warnings reported by
>>> checkpatch-0.21
>>> Errors removed are: ERROR: "foo * bar" should be "foo *bar"
>>> Warnings removed are from extra spaces around parenthesis.
>>> Patch was compile tested against 2.6.27-rc1-mm1+newcodecleanups.patch
>>>
>>> I hope this helps
>>>
>>> Have a nice day
>>> Dushan
>>>
>>> PS. patch is about 400kB so i had to compress it
>>>
>>> On Tue, Aug 5, 2008 at 2:54 PM, Dushan Tcholich <dusanc@gmail.com> wrote:
>>>
>>>> Hello
>>>>
>>>> While running checkpatch on newest r4 in -mm kernels I noticed that I
>>>> already did some cleanups that were reported.
>>>> Then I realised that one patch that I sent that removed about
>>>> 300errors and 500 warnings was misplaced in that patchstorm :) and not
>>>> sent to akpm.
>>>> Here it is again rebased on 2.6.27-rc1-mm1, compile tested.
>>>> Please review
>>>>
>>>> Thanks for your time
>>>> Dushan
>>>>
>>>>
>>
>>
>
>

[-- Attachment #2: newcodecleanups2.patch.tar.gz --]
[-- Type: application/x-gzip, Size: 60388 bytes --]

Re: [PATCH] new code cleanups

[Ryan Hope]

Where are the other 2 patches you mention here, I cant find them anywhere.
-Ryan

On Wed, Aug 6, 2008 at 1:57 PM, Dushan Tcholich <dusanc@gmail.com> wrote:
> Hi
> Have these mails passed to m-l? I can't see these mails in archives,
> but I haven't recieved the rejected mail notifications too.
> Mail me if you need patches sent some other way.
>
> Thanks
> Dushan
>
> On Wed, Aug 6, 2008 at 3:34 PM, Dushan Tcholich <dusanc@gmail.com> wrote:
>> Hello
>> I've made more cleanups ontop of the patch from yesterday.
>> This new patch removes around 1200 errors and 40 warnings reported by
>> checkpatch-0.21
>> Errors removed are: ERROR: "foo * bar" should be "foo *bar"
>> Warnings removed are from extra spaces around parenthesis.
>> Patch was compile tested against 2.6.27-rc1-mm1+newcodecleanups.patch
>>
>> I hope this helps
>>
>> Have a nice day
>> Dushan
>>
>> PS. patch is about 400kB so i had to compress it
>>
>> On Tue, Aug 5, 2008 at 2:54 PM, Dushan Tcholich <dusanc@gmail.com> wrote:
>>> Hello
>>>
>>> While running checkpatch on newest r4 in -mm kernels I noticed that I
>>> already did some cleanups that were reported.
>>> Then I realised that one patch that I sent that removed about
>>> 300errors and 500 warnings was misplaced in that patchstorm :) and not
>>> sent to akpm.
>>> Here it is again rebased on 2.6.27-rc1-mm1, compile tested.
>>> Please review
>>>
>>> Thanks for your time
>>> Dushan
>>>
>>
> --
> To unsubscribe from this list: send the line "unsubscribe reiserfs-devel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>

Re: [PATCH] new code cleanups

[Edward Shishkin]

Ryan Hope wrote:
> Where are the other 2 patches you mention here, I cant find them anywhere.
>   

Note, that the marc mail archive rejects them.
Are you a reiserfs-devel mailing list subscriber?

Edward.

> -Ryan
>
> On Wed, Aug 6, 2008 at 1:57 PM, Dushan Tcholich <dusanc@gmail.com> wrote:
>   
>> Hi
>> Have these mails passed to m-l? I can't see these mails in archives,
>> but I haven't recieved the rejected mail notifications too.
>> Mail me if you need patches sent some other way.
>>
>> Thanks
>> Dushan
>>
>> On Wed, Aug 6, 2008 at 3:34 PM, Dushan Tcholich <dusanc@gmail.com> wrote:
>>     
>>> Hello
>>> I've made more cleanups ontop of the patch from yesterday.
>>> This new patch removes around 1200 errors and 40 warnings reported by
>>> checkpatch-0.21
>>> Errors removed are: ERROR: "foo * bar" should be "foo *bar"
>>> Warnings removed are from extra spaces around parenthesis.
>>> Patch was compile tested against 2.6.27-rc1-mm1+newcodecleanups.patch
>>>
>>> I hope this helps
>>>
>>> Have a nice day
>>> Dushan
>>>
>>> PS. patch is about 400kB so i had to compress it
>>>
>>> On Tue, Aug 5, 2008 at 2:54 PM, Dushan Tcholich <dusanc@gmail.com> wrote:
>>>       
>>>> Hello
>>>>
>>>> While running checkpatch on newest r4 in -mm kernels I noticed that I
>>>> already did some cleanups that were reported.
>>>> Then I realised that one patch that I sent that removed about
>>>> 300errors and 500 warnings was misplaced in that patchstorm :) and not
>>>> sent to akpm.
>>>> Here it is again rebased on 2.6.27-rc1-mm1, compile tested.
>>>> Please review
>>>>
>>>> Thanks for your time
>>>> Dushan
>>>>
>>>>         
>> --
>> To unsubscribe from this list: send the line "unsubscribe reiserfs-devel" in
>> the body of a message to majordomo@vger.kernel.org
>> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>>
>>     
>
>