Re: [Xen-devel] Re: [Qemu-devel] [PATCH 0/7] merge some xen bits into qemu

[Gerd Hoffmann <kraxel@redhat.com>]

Blue Swirl wrote:
>> http://kraxel.fedorapeople.org/patches/qemu-xen/

> 0004-xenpv-groundwork.patch
> 
> You dropped nodisk_ok support from vl.c.

Oh, there are *two* patchsets:
  http://kraxel.fedorapeople.org/patches/qemu-upstream/
  http://kraxel.fedorapeople.org/patches/qemu-xen/

The first also includes some not-yet submitted work-in-progress bits.
It is against upstream qemu svn.  The second is against xen's qemu fork,
so the xen-related changes can get a test-drive there.

Especially the vl.c changes are very different in the two patch sets
because xen's vl.c looks very different (lot of CONFIG_DM conditional
code) and because I don't want to break the command line interface for
now to not break xend's expectations.

That doesn't mean that the nodisk_ok got lost.  It is only in the first
patchset though.

> 0005-xen-backend-core.patch
> 
> container_of could go to osdep.h.

Will do.

> 0006-xen-console-backend.patch
> 
> Not your fault, but a lot of places (at least ps2.c and
> slavio_serial.c) define some kind of ring buffers. Maybe these could
> be consolidated some time.

Will have a look if I find some time.

> 0007-xen-framebuffer-backend.patch
> 
> After you optimized scancode2linux[], it looks like
> atkbd_set2_keycode[] and atkbd_unxlate_table[] are not needed.

Indeed.  Think I just ifdef them out and leave them in there as
documentation.

cheers,
  Gerd

-- 
http://kraxel.fedorapeople.org/xenner/