From: Christian Franke <Christian.Franke@t-online.de>
To: The development of GRUB 2 <grub-devel@gnu.org>
Subject: Re: [PATCH] Fix infinite loop in grub_pit_wait()
Date: Thu, 07 Aug 2008 21:46:28 +0200 [thread overview]
Message-ID: <489B5114.7070201@t-online.de> (raw)
In-Reply-To: <87hc9wssed.fsf@xs4all.nl>
Marco Gerards wrote:
> Christian Franke <Christian.Franke@t-online.de> writes:
>
> ...
>> (grub_pit_wait): Add enable/disable of the timer2 gate
>> bit of port 0x61. This fixes a possible infinite loop.
>>
>
> Small nitpick: use a double space
>
>
>> ...
>> +
>> + /* Disable timer2 gate and speaker. */
>> + grub_outb (grub_inb (TIMER2_REG_LATCH) & ~ (TIMER2_SPEAKER | TIMER2_GATE), TIMER2_REG_LATCH);
>>
> These lines are too long, please break them properly.
>
>
Included in commit. Thanks.
Christian
prev parent reply other threads:[~2008-08-07 19:46 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-07 15:32 [PATCH] Fix infinite loop in grub_pit_wait() Christian Franke
2008-08-07 16:10 ` Robert Millan
2008-08-07 19:44 ` Christian Franke
2008-08-07 16:26 ` Marco Gerards
2008-08-07 19:46 ` Christian Franke [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=489B5114.7070201@t-online.de \
--to=christian.franke@t-online.de \
--cc=grub-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.