All of lore.kernel.org
 help / color / mirror / Atom feed
From: "H. Peter Anvin" <hpa@kernel.org>
To: Zachary Amsden <zach@vmware.com>
Cc: Alok Kataria <akataria@vmware.com>,
	"torvalds@linux-foundation.org" <torvalds@linux-foundation.org>,
	Ingo Molnar <mingo@elte.hu>,
	the arch/x86 maintainers <x86@kernel.org>,
	LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH]Fix broken VMI in 2.6.27-rc..
Date: Thu, 07 Aug 2008 14:52:03 -0700	[thread overview]
Message-ID: <489B6E83.7000202@kernel.org> (raw)
In-Reply-To: <1218145344.20178.347.camel@bodhitayantram.eng.vmware.com>

Zachary Amsden wrote:
>>>
>> Okay, you lost me about halfway through that... could you perhaps
>> describe the problem from the beginning, exactly what you're trying to do?
> 
> A kernel compiled with VMI enabled may run on a non-VMI platform.  If
> that is the case, the fixmap should not be relocated.  If however, a VMI
> ROM is found, we need to hijack up to 64-MB of linear address space from
> the top of memory down.  This means moving the fixmap down by the same
> amount.
> 

I take it there are no alternatives other than putting this at the end 
of memory?

> Right now the code is structured in such a way that it wants to know how
> much physical memory there is, so it can register a mapping table for
> mapping linear addresses in the lowmem area to physical addresses.  This
> causes the code to depend on max_low_pfn being initialized, which
> accounts for the current placement.
> 
> But it also must be called before anything that creates the fixmap,
> because the same code which registers the linear address mapping also
> reserves high memory above the fixmap.
> 
> My point is 1) these could be two separate calls, or 2) the lowmem
> mapping table need not depend on max_low_pfn at all, it is safe to
> create an extra large mapping which covers all possible lowmem instead
> of the physical ram that is actually available.

Realistically speaking, any (virtual) machine which does *not* have a 
full complement of lowmem (i.e. less than 896 MB in the common case) 
will not suffer significatly from losing a few megabytes of address space.

	-hpa


  reply	other threads:[~2008-08-07 21:52 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-08-07 19:12 [PATCH]Fix broken VMI in 2.6.27-rc Alok Kataria
2008-08-07 21:20 ` H. Peter Anvin
2008-08-07 21:27   ` Zachary Amsden
2008-08-07 21:34     ` H. Peter Anvin
2008-08-07 21:42       ` Zachary Amsden
2008-08-07 21:52         ` H. Peter Anvin [this message]
2008-08-07 21:55           ` Zachary Amsden
2008-08-07 22:17             ` H. Peter Anvin
2008-08-07 22:38               ` Linus Torvalds
2008-08-07 22:58                 ` H. Peter Anvin
2008-08-07 23:08                   ` Linus Torvalds
2008-08-07 23:12                     ` H. Peter Anvin
2008-08-07 23:26                     ` Zachary Amsden
2008-08-07 23:49                       ` Jeremy Fitzhardinge
2008-08-07 23:23               ` Jeremy Fitzhardinge
2008-08-08 19:15           ` Alok Kataria
2008-08-08 22:23             ` H. Peter Anvin
2008-08-07 23:21     ` Jeremy Fitzhardinge
2008-08-07 23:27       ` H. Peter Anvin
2008-08-07 23:46         ` Jeremy Fitzhardinge
2008-08-07 23:51           ` H. Peter Anvin
2008-08-08  0:01             ` Yinghai Lu
2008-08-08  0:11               ` H. Peter Anvin
2008-08-08  0:10             ` Jeremy Fitzhardinge
2008-08-08  0:13               ` H. Peter Anvin
2008-08-08  0:23                 ` Jeremy Fitzhardinge
2008-08-08  0:29                   ` H. Peter Anvin
2008-08-08  6:10                 ` Jeremy Fitzhardinge
2008-08-08 16:13                   ` H. Peter Anvin
2008-08-08  1:14               ` Zachary Amsden
2008-08-08  1:19                 ` H. Peter Anvin
2008-08-08  1:28                   ` Zachary Amsden
2008-08-07 21:41   ` Alok Kataria

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=489B6E83.7000202@kernel.org \
    --to=hpa@kernel.org \
    --cc=akataria@vmware.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=torvalds@linux-foundation.org \
    --cc=x86@kernel.org \
    --cc=zach@vmware.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.