From: Avi Kivity <avi@qumranet.com>
To: Sebastian Herbszt <herbszt@gmx.de>
Cc: "Yang, Sheng" <sheng.yang@intel.com>, kvm@vger.kernel.org
Subject: Re: [PATCH] kvm: bios: Put AP boot up code to 0x1000
Date: Sun, 10 Aug 2008 10:50:04 +0300 [thread overview]
Message-ID: <489E9DAC.3030400@qumranet.com> (raw)
In-Reply-To: <02a901c8f80f$940da820$0201a8c0@zeug>
Sebastian Herbszt wrote:
>
> The AP enters HALT state with IF=0. What can make it resume at the
> following "jmp 1b"? NMI? SMI?
>
Yes, but also INIT.
We might ignore IF=0 for hlt (which would be a bug).
> I think i read something about a need for 4kb alignment for the
> startup vector in the mp specs. AP_BOOT_ADDR is currently
> at 0x10000 (16 x 4kb).
>
Yes, the SIPI address is 4K x sipi vector.
> - Sebastian
>
> --- rombios32start.S.orig Wed Aug 6 21:37:22 2008
> +++ rombios32start.S Wed Aug 6 21:39:17 2008
> @@ -40,6 +40,7 @@ _start:
>
> .code16
> smp_ap_boot_code_start:
> + cli
> xor %ax, %ax
> mov %ax, %ds
> xor %eax, %eax
> @@ -60,6 +61,7 @@ smp_ap_boot_code_start:
> 12:
>
> incw CPU_COUNT_ADDR
> + ljmp $0xe000, $(1f-_start)
> 1:
> hlt
> jmp 1b
>
Looks good. Please post with signoff and changelog.
--
error compiling committee.c: too many arguments to function
next prev parent reply other threads:[~2008-08-10 7:50 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-31 2:43 [PATCH] kvm: bios: Put AP boot up code to 0x1000 Yang, Sheng
2008-07-31 6:00 ` Yang, Sheng
2008-07-31 6:41 ` Avi Kivity
2008-07-31 9:09 ` Yang, Sheng
2008-07-31 9:46 ` Avi Kivity
2008-08-01 15:49 ` H. Peter Anvin
2008-07-31 21:15 ` Sebastian Herbszt
2008-08-01 1:19 ` Yang, Sheng
2008-08-02 19:30 ` Sebastian Herbszt
2008-08-05 8:14 ` Yang, Sheng
2008-08-06 21:56 ` Sebastian Herbszt
2008-08-10 7:50 ` Avi Kivity [this message]
2008-08-13 23:00 ` Sebastian Herbszt
2008-08-14 6:08 ` Avi Kivity
2008-08-17 22:35 ` [PATCH] kvm: bios: end AP boot code execution in rombios Sebastian Herbszt
2008-08-18 2:33 ` Anthony Liguori
2008-08-18 2:45 ` Yang, Sheng
2008-08-18 10:21 ` Avi Kivity
2008-08-18 10:22 ` Avi Kivity
2008-08-19 23:06 ` Sebastian Herbszt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=489E9DAC.3030400@qumranet.com \
--to=avi@qumranet.com \
--cc=herbszt@gmx.de \
--cc=kvm@vger.kernel.org \
--cc=sheng.yang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.