All of lore.kernel.org
 help / color / mirror / Atom feed
From: Anthony Liguori <anthony@codemonkey.ws>
To: Sebastian Herbszt <herbszt@gmx.de>
Cc: Avi Kivity <avi@qumranet.com>,
	"Yang, Sheng" <sheng.yang@intel.com>,
	kvm@vger.kernel.org
Subject: Re: [PATCH] kvm: bios: end AP boot code execution in rombios
Date: Sun, 17 Aug 2008 21:33:11 -0500	[thread overview]
Message-ID: <48A8DF67.90600@codemonkey.ws> (raw)
In-Reply-To: <1219012543$2777@local>

Sebastian Herbszt wrote:
> Jump to rombios before executing the halt loop.
>   

Why?  More importantly, why is this specific to KVM?

Regards,

Anthony Liguori

> Signed-off-by: Sebastian Herbszt <herbszt@gmx.de>
>
> diff -uNrp a/bios/rombios32start.S b/bios/rombios32start.S
> --- a/bios/rombios32start.S	2008-08-17 23:30:42.000000000 +0200
> +++ b/bios/rombios32start.S	2008-08-17 23:38:42.000000000 +0200
> @@ -40,6 +40,7 @@ _start:
>  
>    .code16
>  smp_ap_boot_code_start:
> +  cli
>    xor %ax, %ax
>    mov %ax, %ds
>    xor %eax, %eax
> @@ -60,6 +61,7 @@ smp_ap_boot_code_start:
>  12:
>  
>    incw CPU_COUNT_ADDR
> +  ljmp $0xe000, $(1f-_start)
>  1:
>    hlt
>    jmp 1b
>
> --
> To unsubscribe from this list: send the line "unsubscribe kvm" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>   


  reply	other threads:[~2008-08-18  2:33 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-07-31  2:43 [PATCH] kvm: bios: Put AP boot up code to 0x1000 Yang, Sheng
2008-07-31  6:00 ` Yang, Sheng
2008-07-31  6:41   ` Avi Kivity
2008-07-31  9:09     ` Yang, Sheng
2008-07-31  9:46       ` Avi Kivity
2008-08-01 15:49         ` H. Peter Anvin
2008-07-31 21:15 ` Sebastian Herbszt
2008-08-01  1:19   ` Yang, Sheng
2008-08-02 19:30     ` Sebastian Herbszt
2008-08-05  8:14       ` Yang, Sheng
2008-08-06 21:56         ` Sebastian Herbszt
2008-08-10  7:50           ` Avi Kivity
2008-08-13 23:00             ` Sebastian Herbszt
2008-08-14  6:08               ` Avi Kivity
2008-08-17 22:35             ` [PATCH] kvm: bios: end AP boot code execution in rombios Sebastian Herbszt
2008-08-18  2:33               ` Anthony Liguori [this message]
2008-08-18  2:45                 ` Yang, Sheng
2008-08-18 10:21                   ` Avi Kivity
2008-08-18 10:22               ` Avi Kivity
2008-08-19 23:06                 ` Sebastian Herbszt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=48A8DF67.90600@codemonkey.ws \
    --to=anthony@codemonkey.ws \
    --cc=avi@qumranet.com \
    --cc=herbszt@gmx.de \
    --cc=kvm@vger.kernel.org \
    --cc=sheng.yang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.