All of lore.kernel.org
 help / color / mirror / Atom feed
From: Benny Halevy <bhalevy@panasas.com>
To: Linus Torvalds <torvalds@linux-foundation.org>,
	Adrian Bunk <bunk@kernel.org>
Cc: "J. Bruce Fields" <bfields@citi.umich.edu>,
	neilb@suse.de, linux-nfs@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [2.6 patch] uninline nfsd4_op_name()
Date: Sun, 10 Aug 2008 14:32:31 +0300	[thread overview]
Message-ID: <489ED1CF.8000308@panasas.com> (raw)
In-Reply-To: <alpine.LFD.1.10.0808081120570.3462-nfNrOhbfy2R17+2ddN/4kux8cNe9sq/dYPYVAmT7z5s@public.gmane.org>

Linus Torvalds wrote:
> 
> On Fri, 8 Aug 2008, Adrian Bunk wrote:
>> There doesn't seem to be a compelling reason why nfsd4_op_name() is 
>> marked as "inline":

Agreed.

> 
> It should also return a "const char *", I think.
> 
> Since it does.

Right.

> 
> 		Linus

Thanks for picking this up,

Benny

WARNING: multiple messages have this Message-ID (diff)
From: Benny Halevy <bhalevy@panasas.com>
To: Linus Torvalds <torvalds@linux-foundation.org>,
	Adrian Bunk <bunk@kernel.org>
Cc: "J. Bruce Fields" <bfields@citi.umich.edu>,
	neilb@suse.de, linux-nfs@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [2.6 patch] uninline nfsd4_op_name()
Date: Sun, 10 Aug 2008 14:32:31 +0300	[thread overview]
Message-ID: <489ED1CF.8000308@panasas.com> (raw)
In-Reply-To: <alpine.LFD.1.10.0808081120570.3462@nehalem.linux-foundation.org>

Linus Torvalds wrote:
> 
> On Fri, 8 Aug 2008, Adrian Bunk wrote:
>> There doesn't seem to be a compelling reason why nfsd4_op_name() is 
>> marked as "inline":

Agreed.

> 
> It should also return a "const char *", I think.
> 
> Since it does.

Right.

> 
> 		Linus

Thanks for picking this up,

Benny

  parent reply	other threads:[~2008-08-10 11:33 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-08-08 16:26 [2.6 patch] uninline nfsd4_op_name() Adrian Bunk
     [not found] ` <20080808162642.GG14495-re2QNgSbS3j4D6uPqz5PAwR5/fbUUdgG@public.gmane.org>
2008-08-08 18:25   ` Linus Torvalds
2008-08-08 18:25     ` Linus Torvalds
     [not found]     ` <alpine.LFD.1.10.0808081120570.3462-nfNrOhbfy2R17+2ddN/4kux8cNe9sq/dYPYVAmT7z5s@public.gmane.org>
2008-08-10 11:32       ` Benny Halevy [this message]
2008-08-10 11:32         ` Benny Halevy
2008-08-11  3:03         ` J. Bruce Fields
2008-08-11  8:47           ` Benny Halevy
2008-08-11 15:39             ` J. Bruce Fields

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=489ED1CF.8000308@panasas.com \
    --to=bhalevy@panasas.com \
    --cc=akpm@linux-foundation.org \
    --cc=bfields@citi.umich.edu \
    --cc=bunk@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-nfs@vger.kernel.org \
    --cc=neilb@suse.de \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.