From: Christoph Lameter <cl@linux-foundation.org>
To: "Frank Ch. Eigler" <fche@redhat.com>
Cc: Steven Rostedt <rostedt@goodmis.org>,
Pekka Enberg <penberg@cs.helsinki.fi>,
Eduard - Gabriel Munteanu <eduard.munteanu@linux360.ro>,
mathieu.desnoyers@polymtl.ca, linux-mm@kvack.org,
linux-kernel@vger.kernel.org, rdunlap@xenotime.net,
mpm@selenic.com, tglx@linutronix.de
Subject: Re: [PATCH 4/5] kmemtrace: SLUB hooks.
Date: Mon, 11 Aug 2008 10:48:29 -0500 [thread overview]
Message-ID: <48A05F4D.4080404@linux-foundation.org> (raw)
In-Reply-To: <y0mhc9ra7m6.fsf@ton.toronto.redhat.com>
Frank Ch. Eigler wrote:
> Christoph Lameter <cl@linux-foundation.org> writes:
>
>> [...]
>>> There should be no extra function calls when this is configured on but
>>> tracing disabled. We try very hard to keep the speed of the tracer as
>>> close to a non tracing kernel as possible when tracing is disabled.
>> Makes sense. But then we have even more code bloat because of the
>> tests that are inserted in all call sites of kmalloc.
>
> Are you talking about the tests that implement checking whether a
> marker is active or not? Those checks are already efficient, and will
> get more so with the "immediate values" optimization in or near the
> tree.
AFAICT: Each test also adds an out of line call to the tracing facility.
WARNING: multiple messages have this Message-ID (diff)
From: Christoph Lameter <cl@linux-foundation.org>
To: "Frank Ch. Eigler" <fche@redhat.com>
Cc: Steven Rostedt <rostedt@goodmis.org>,
Pekka Enberg <penberg@cs.helsinki.fi>,
Eduard - Gabriel Munteanu <eduard.munteanu@linux360.ro>,
mathieu.desnoyers@polymtl.ca, linux-mm@kvack.org,
linux-kernel@vger.kernel.org, rdunlap@xenotime.net,
mpm@selenic.com, tglx@linutronix.de
Subject: Re: [PATCH 4/5] kmemtrace: SLUB hooks.
Date: Mon, 11 Aug 2008 10:48:29 -0500 [thread overview]
Message-ID: <48A05F4D.4080404@linux-foundation.org> (raw)
In-Reply-To: <y0mhc9ra7m6.fsf@ton.toronto.redhat.com>
Frank Ch. Eigler wrote:
> Christoph Lameter <cl@linux-foundation.org> writes:
>
>> [...]
>>> There should be no extra function calls when this is configured on but
>>> tracing disabled. We try very hard to keep the speed of the tracer as
>>> close to a non tracing kernel as possible when tracing is disabled.
>> Makes sense. But then we have even more code bloat because of the
>> tests that are inserted in all call sites of kmalloc.
>
> Are you talking about the tests that implement checking whether a
> marker is active or not? Those checks are already efficient, and will
> get more so with the "immediate values" optimization in or near the
> tree.
AFAICT: Each test also adds an out of line call to the tracing facility.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2008-08-11 15:50 UTC|newest]
Thread overview: 68+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-10 17:14 [PATCH 0/5] kmemtrace Eduard - Gabriel Munteanu
2008-08-10 17:14 ` Eduard - Gabriel Munteanu
2008-08-10 17:14 ` [PATCH 1/5] kmemtrace: Core implementation Eduard - Gabriel Munteanu
2008-08-10 17:14 ` Eduard - Gabriel Munteanu
2008-08-10 17:14 ` [PATCH 2/5] kmemtrace: Additional documentation Eduard - Gabriel Munteanu
2008-08-10 17:14 ` Eduard - Gabriel Munteanu
2008-08-10 17:14 ` [PATCH 3/5] kmemtrace: SLAB hooks Eduard - Gabriel Munteanu
2008-08-10 17:14 ` Eduard - Gabriel Munteanu
2008-08-10 17:14 ` [PATCH 4/5] kmemtrace: SLUB hooks Eduard - Gabriel Munteanu
2008-08-10 17:14 ` Eduard - Gabriel Munteanu
2008-08-10 17:14 ` [PATCH 5/5] kmemtrace: SLOB hooks Eduard - Gabriel Munteanu
2008-08-10 17:14 ` Eduard - Gabriel Munteanu
2008-08-10 17:48 ` Pekka Enberg
2008-08-10 17:48 ` Pekka Enberg
2008-08-10 23:18 ` Matt Mackall
2008-08-10 23:18 ` Matt Mackall
2008-08-12 6:46 ` Pekka Enberg
2008-08-12 6:46 ` Pekka Enberg
2008-08-11 14:04 ` [PATCH 4/5] kmemtrace: SLUB hooks Christoph Lameter
2008-08-11 14:04 ` Christoph Lameter
2008-08-11 14:09 ` Pekka Enberg
2008-08-11 14:09 ` Pekka Enberg
2008-08-11 14:13 ` Christoph Lameter
2008-08-11 14:13 ` Christoph Lameter
2008-08-11 14:16 ` Pekka Enberg
2008-08-11 14:16 ` Pekka Enberg
2008-08-11 14:21 ` Christoph Lameter
2008-08-11 14:21 ` Christoph Lameter
2008-08-11 14:22 ` Pekka Enberg
2008-08-11 14:22 ` Pekka Enberg
2008-08-12 15:29 ` Eduard - Gabriel Munteanu
2008-08-12 15:29 ` Eduard - Gabriel Munteanu
2008-08-12 15:43 ` Mathieu Desnoyers
2008-08-12 15:43 ` Mathieu Desnoyers
2008-08-13 2:09 ` Matt Mackall
2008-08-13 2:09 ` Matt Mackall
2008-08-11 14:36 ` Steven Rostedt
2008-08-11 14:36 ` Steven Rostedt
2008-08-11 18:28 ` Mathieu Desnoyers
2008-08-11 18:28 ` Mathieu Desnoyers
2008-08-11 14:30 ` Steven Rostedt
2008-08-11 14:30 ` Steven Rostedt
2008-08-11 14:37 ` Christoph Lameter
2008-08-11 14:37 ` Christoph Lameter
2008-08-11 15:34 ` Frank Ch. Eigler
2008-08-11 15:34 ` Frank Ch. Eigler
2008-08-11 15:48 ` Christoph Lameter [this message]
2008-08-11 15:48 ` Christoph Lameter
2008-08-11 15:54 ` Steven Rostedt
2008-08-11 15:54 ` Steven Rostedt
2008-08-11 15:57 ` Frank Ch. Eigler
2008-08-11 15:57 ` Frank Ch. Eigler
2008-08-11 18:29 ` Mathieu Desnoyers
2008-08-11 18:29 ` Mathieu Desnoyers
2008-08-12 15:25 ` Eduard - Gabriel Munteanu
2008-08-12 15:25 ` Eduard - Gabriel Munteanu
2008-08-12 6:46 ` [PATCH 3/5] kmemtrace: SLAB hooks Pekka Enberg
2008-08-12 6:46 ` Pekka Enberg
2008-08-12 6:46 ` [PATCH 2/5] kmemtrace: Additional documentation Pekka Enberg
2008-08-12 6:46 ` Pekka Enberg
2008-08-18 19:57 ` Randy Dunlap
2008-08-18 19:57 ` Randy Dunlap
2008-08-12 6:46 ` [PATCH 1/5] kmemtrace: Core implementation Pekka Enberg
2008-08-12 6:46 ` Pekka Enberg
-- strict thread matches above, loose matches on Subject: below --
2008-08-19 17:43 [PATCH 1/5] Revert "kmemtrace: fix printk format warnings" Eduard - Gabriel Munteanu
2008-08-19 17:43 ` [PATCH 2/5] kmemtrace: Better alternative to " Eduard - Gabriel Munteanu
2008-08-19 17:43 ` [PATCH 3/5] SLUB: Replace __builtin_return_address(0) with _RET_IP_ Eduard - Gabriel Munteanu
2008-08-19 17:43 ` [PATCH 4/5] kmemtrace: SLUB hooks Eduard - Gabriel Munteanu
2008-08-19 17:43 ` Eduard - Gabriel Munteanu
2008-08-19 19:10 ` Pekka Enberg
2008-08-19 19:10 ` Pekka Enberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48A05F4D.4080404@linux-foundation.org \
--to=cl@linux-foundation.org \
--cc=eduard.munteanu@linux360.ro \
--cc=fche@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mathieu.desnoyers@polymtl.ca \
--cc=mpm@selenic.com \
--cc=penberg@cs.helsinki.fi \
--cc=rdunlap@xenotime.net \
--cc=rostedt@goodmis.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.