All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sander Marechal <s.marechal@jejik.com>
To: The development of GRUB 2 <grub-devel@gnu.org>
Subject: Re: [PATCH] Grub2 cannot find LVM volume groups with a dash (-) in the  name
Date: Mon, 11 Aug 2008 23:48:33 +0200	[thread overview]
Message-ID: <48A0B3B1.6010507@jejik.com> (raw)
In-Reply-To: <1218471512.6939.19.camel@fz.local>

Felix Zielcke wrote:
> Well attached is now my cute little asprintf patch with a very ugly LVM
> part.
> 
> It works for
> 
> volumegroup: linuxvg
> logicalvolume: lvol0
> /dev/mapper/linuxvg-lvol0
> 
> volume group: m-y--vg
> logical volume: l-vol--0
> /dev/mapper/m--y----vg-l--vol----0
> 
> 
> Please comment this, please give me hints how to make it better.
> I don't like the code myself but it seems like we should handle this
> double dash problem :(

I commented on this on #grub but will post here as well, to preserve it
for posterity :-)

I tested the patch against grub 20080724 in Debian Lenny and it works
great :-) I can't comment on the rest of the code. I'm not a grub developer.

-- 
Sander Marechal



  reply	other threads:[~2008-08-11 21:48 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20080808202337.3440.57502.reportbug@sylvester.jejik.com.jejik.com>
2008-08-09 10:26 ` Bug#494383: grub-pc: Grub2 cannot find LVM volume groups with a dash (-) in the name Felix Zielcke
2008-08-09 12:55   ` Felix Zielcke
2008-08-10 13:19   ` Sander Marechal
2008-08-11 16:18     ` [PATCH] " Felix Zielcke
2008-08-11 21:48       ` Sander Marechal [this message]
2008-08-14 17:34       ` Felix Zielcke
2008-08-14 18:03         ` Robert Millan
2008-08-14 19:32           ` Felix Zielcke
2008-08-14 20:38             ` Robert Millan
2008-08-14 21:15               ` Felix Zielcke
2008-08-18 15:05                 ` Felix Zielcke
2008-08-18 15:16                   ` Felix Zielcke
2008-09-01  7:08                     ` Felix Zielcke
2008-09-01 22:14                   ` Robert Millan
2008-09-01 22:46                     ` Felix Zielcke
2008-09-02  8:28                       ` Felix Zielcke
2008-09-02 14:59                         ` Vesa Jääskeläinen
2008-09-02 15:59                           ` Felix Zielcke
2008-09-02 16:21                             ` Vesa Jääskeläinen
2008-09-04 19:56                             ` Felix Zielcke
2008-09-02 13:37                       ` Robert Millan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=48A0B3B1.6010507@jejik.com \
    --to=s.marechal@jejik.com \
    --cc=grub-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.