From: Yosuke Iwamatsu <y-iwamatsu@ab.jp.nec.com>
To: Ian Jackson <Ian.Jackson@eu.citrix.com>
Cc: xen-devel@lists.xensource.com
Subject: [PATCH] stubdom: Fix the Makefile
Date: Tue, 12 Aug 2008 13:59:09 +0900 [thread overview]
Message-ID: <48A1189D.7050609@ab.jp.nec.com> (raw)
In-Reply-To: <18592.6365.409636.426364@mariner.uk.xensource.com>
Ian Jackson wrote:
> Yosuke Iwamatsu writes ("[Xen-devel] [PATCH] stubdom: Fix the Makefile"):
>> While building stubdom, I saw an error.
>>
>> install: cannot stat `lib/{config,header,pci,types}.h': No such file
>> or directory
>>
>> It seems brace expansion is not available in some environments, so we
>> had better avoid using it.
>
> I see that this has been committed already. However for future
> reference I think a better answer is to say
> SHELL=/bin/bash
> in some appropriate place.
>
> This kind of brace expansion is an excellent trick for removing
> duplication in Makefile runes and our build system depends on bash
> anyway.
I agree that brace expansion is convenient and sometimes desireble.
One thing I want to clarify is that, does our build system really depend
on bash? Non-linux systems as *BSD and Solaris are not likely to have
bash, so 'SHELL=/bin/bash' won't work. (I usually use a linux box myself
and assuming that bash is always available is O.K. to me, though.)
-- Yosuke
prev parent reply other threads:[~2008-08-12 4:59 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-04 10:08 [PATCH] stubdom: Fix the Makefile Yosuke Iwamatsu
2008-08-11 10:47 ` Ian Jackson
2008-08-12 4:59 ` Yosuke Iwamatsu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48A1189D.7050609@ab.jp.nec.com \
--to=y-iwamatsu@ab.jp.nec.com \
--cc=Ian.Jackson@eu.citrix.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.