From: Pekka Enberg <penberg@cs.helsinki.fi>
To: Christoph Lameter <cl@linux-foundation.org>,
Pekka Enberg <penberg@cs.helsinki.fi>,
akpm@linux-foundation.org, Christoph Lameter <clameter@sgi.com>,
linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org,
Mel Gorman <mel@skynet.ie>,
andi@firstfloor.org, Rik van Riel <riel@redhat.com>,
mpm@selenic.com
Subject: Re: [patch 15/19] Filesystem: XFS slab defragmentation
Date: Tue, 12 Aug 2008 10:08:07 +0300 [thread overview]
Message-ID: <48A136D7.4080505@cs.helsinki.fi> (raw)
In-Reply-To: <20080812002057.GH6119@disturbed>
Dave Chinner wrote:
> On Mon, Aug 11, 2008 at 08:06:31AM -0700, Christoph Lameter wrote:
>> Support inode defragmentation for xfs
>>
>> Reviewed-by: Rik van Riel <riel@redhat.com>
>> Signed-off-by: Christoph Lameter <clameter@sgi.com>
>> Signed-off-by: Christoph Lameter <cl@linux-foundation.org>
>>
>> ---
>> fs/xfs/linux-2.6/xfs_super.c | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> Index: linux-next/fs/xfs/linux-2.6/xfs_super.c
>> ===================================================================
>> --- linux-next.orig/fs/xfs/linux-2.6/xfs_super.c 2008-08-11 07:42:11.892359719 -0700
>> +++ linux-next/fs/xfs/linux-2.6/xfs_super.c 2008-08-11 07:47:05.072348463 -0700
>> @@ -1947,6 +1947,7 @@ xfs_init_zones(void)
>> xfs_ioend_zone = kmem_zone_init(sizeof(xfs_ioend_t), "xfs_ioend");
>> if (!xfs_ioend_zone)
>> goto out_destroy_vnode_zone;
>> + kmem_cache_setup_defrag(xfs_vnode_zone, get_inodes, kick_inodes);
>>
>> xfs_ioend_pool = mempool_create_slab_pool(4 * MAX_BUF_PER_PAGE,
>> xfs_ioend_zone);
>
> Please update this patch as per my last comment.
Christoph, I'm dropping this patch from my tree.
WARNING: multiple messages have this Message-ID (diff)
From: Pekka Enberg <penberg@cs.helsinki.fi>
To: Christoph Lameter <cl@linux-foundation.org>,
Pekka Enberg <penberg@cs.helsinki.fi>,
akpm@linux-foundation.org, Christoph Lameter <clameter@sgi.com>,
linux-kernel@vger.kernel.org, linu
Subject: Re: [patch 15/19] Filesystem: XFS slab defragmentation
Date: Tue, 12 Aug 2008 10:08:07 +0300 [thread overview]
Message-ID: <48A136D7.4080505@cs.helsinki.fi> (raw)
In-Reply-To: <20080812002057.GH6119@disturbed>
Dave Chinner wrote:
> On Mon, Aug 11, 2008 at 08:06:31AM -0700, Christoph Lameter wrote:
>> Support inode defragmentation for xfs
>>
>> Reviewed-by: Rik van Riel <riel@redhat.com>
>> Signed-off-by: Christoph Lameter <clameter@sgi.com>
>> Signed-off-by: Christoph Lameter <cl@linux-foundation.org>
>>
>> ---
>> fs/xfs/linux-2.6/xfs_super.c | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> Index: linux-next/fs/xfs/linux-2.6/xfs_super.c
>> ===================================================================
>> --- linux-next.orig/fs/xfs/linux-2.6/xfs_super.c 2008-08-11 07:42:11.892359719 -0700
>> +++ linux-next/fs/xfs/linux-2.6/xfs_super.c 2008-08-11 07:47:05.072348463 -0700
>> @@ -1947,6 +1947,7 @@ xfs_init_zones(void)
>> xfs_ioend_zone = kmem_zone_init(sizeof(xfs_ioend_t), "xfs_ioend");
>> if (!xfs_ioend_zone)
>> goto out_destroy_vnode_zone;
>> + kmem_cache_setup_defrag(xfs_vnode_zone, get_inodes, kick_inodes);
>>
>> xfs_ioend_pool = mempool_create_slab_pool(4 * MAX_BUF_PER_PAGE,
>> xfs_ioend_zone);
>
> Please update this patch as per my last comment.
Christoph, I'm dropping this patch from my tree.
next prev parent reply other threads:[~2008-08-12 7:11 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-11 15:06 [patch 00/19] Slab Fragmentation Reduction V14 Christoph Lameter
2008-08-11 15:06 ` [patch 01/19] slub: Add defrag_ratio field and sysfs support Christoph Lameter
2008-08-13 0:40 ` Greg KH
2008-08-11 15:06 ` [patch 02/19] slub: Replace ctor field with ops field in /sys/slab/* Christoph Lameter
2008-08-11 15:06 ` [patch 03/19] slub: Add get() and kick() methods Christoph Lameter
2008-08-11 15:06 ` [patch 04/19] slub: Sort slab cache list and establish maximum objects for defrag slabs Christoph Lameter
2008-08-11 15:06 ` [patch 05/19] slub: Slab defrag core Christoph Lameter
2008-08-11 15:06 ` [patch 06/19] slub: Add KICKABLE to avoid repeated kick() attempts Christoph Lameter
2008-08-11 15:06 ` [patch 07/19] slub: Extend slabinfo to support -D and -F options Christoph Lameter
2008-08-11 15:06 ` [patch 08/19] slub/slabinfo: add defrag statistics Christoph Lameter
2008-08-11 15:06 ` [patch 09/19] slub: Trigger defragmentation from memory reclaim Christoph Lameter
2008-08-11 15:06 ` [patch 10/19] buffer heads: Support slab defrag Christoph Lameter
2008-08-11 15:06 ` [patch 11/19] inodes: Support generic defragmentation Christoph Lameter
2008-08-11 15:06 ` [patch 12/19] Filesystem: Ext2 filesystem defrag Christoph Lameter
2008-08-11 15:06 ` [patch 13/19] Filesystem: Ext3 " Christoph Lameter
2008-08-11 15:06 ` [patch 14/19] Filesystem: Ext4 " Christoph Lameter
2008-08-11 15:06 ` [patch 15/19] Filesystem: XFS slab defragmentation Christoph Lameter
2008-08-12 0:20 ` Dave Chinner
2008-08-12 7:08 ` Pekka Enberg [this message]
2008-08-12 7:08 ` Pekka Enberg
2008-08-12 18:21 ` Christoph Lameter
2008-08-13 6:38 ` Pekka Enberg
2008-08-11 15:06 ` [patch 16/19] Filesystem: /proc filesystem support for slab defrag Christoph Lameter
2008-08-11 15:06 ` [patch 17/19] Filesystem: Slab defrag: Reiserfs support Christoph Lameter
2008-08-11 15:06 ` [patch 18/19] dentries: Add constructor Christoph Lameter
2008-08-13 7:12 ` Pekka Enberg
2008-08-11 15:06 ` [patch 19/19] dentries: dentry defragmentation Christoph Lameter
2008-08-12 6:50 ` [patch 00/19] Slab Fragmentation Reduction V14 Pekka Enberg
-- strict thread matches above, loose matches on Subject: below --
2008-05-10 2:21 [patch 00/19] Slab Fragmentation Reduction V13 Christoph Lameter
2008-05-10 2:21 ` [patch 15/19] Filesystem: XFS slab defragmentation Christoph Lameter
2008-08-03 1:42 ` Dave Chinner
2008-08-04 13:36 ` Christoph Lameter
2008-08-04 13:36 ` Christoph Lameter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48A136D7.4080505@cs.helsinki.fi \
--to=penberg@cs.helsinki.fi \
--cc=akpm@linux-foundation.org \
--cc=andi@firstfloor.org \
--cc=cl@linux-foundation.org \
--cc=clameter@sgi.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mel@skynet.ie \
--cc=mpm@selenic.com \
--cc=riel@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.