* [PATCH] Xend: Fix Setting up Platform Parameters
@ 2008-08-13 12:06 Yosuke Iwamatsu
2008-08-13 12:29 ` Keir Fraser
0 siblings, 1 reply; 3+ messages in thread
From: Yosuke Iwamatsu @ 2008-08-13 12:06 UTC (permalink / raw)
To: xen-devel
Make sure that 'PV_kernel' config param is not blank when assigning it
to 'loader' param. This fixes a failure of 'xm create' via xen-api.
Signed-off-by: Yosuke Iwamatsu <y-iwamatsu@ab.jp.nec.com>
diff -r 2c63cf7b042d tools/python/xen/xend/XendConfig.py
--- a/tools/python/xen/xend/XendConfig.py Tue Aug 12 10:23:34 2008 +0100
+++ b/tools/python/xen/xend/XendConfig.py Wed Aug 13 20:43:41 2008 +0900
@@ -448,7 +448,7 @@ class XendConfig(dict):
self['platform']['hpet'] = 0
if 'loader' not in self['platform']:
# Old configs may have hvmloader set as PV_kernel param
- if self.has_key('PV_kernel'):
+ if self.has_key('PV_kernel') and self['PV_kernel'] != '':
self['platform']['loader'] = self['PV_kernel']
self['PV_kernel'] = ''
else:
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] Xend: Fix Setting up Platform Parameters
2008-08-13 12:06 [PATCH] Xend: Fix Setting up Platform Parameters Yosuke Iwamatsu
@ 2008-08-13 12:29 ` Keir Fraser
2008-08-13 12:34 ` Keir Fraser
0 siblings, 1 reply; 3+ messages in thread
From: Keir Fraser @ 2008-08-13 12:29 UTC (permalink / raw)
To: Yosuke Iwamatsu, xen-devel
So setting self['platform']['loader'] to '' instead of None can break
booting? How?
-- Keir
On 13/8/08 13:06, "Yosuke Iwamatsu" <y-iwamatsu@ab.jp.nec.com> wrote:
> Make sure that 'PV_kernel' config param is not blank when assigning it
> to 'loader' param. This fixes a failure of 'xm create' via xen-api.
>
> Signed-off-by: Yosuke Iwamatsu <y-iwamatsu@ab.jp.nec.com>
>
> diff -r 2c63cf7b042d tools/python/xen/xend/XendConfig.py
> --- a/tools/python/xen/xend/XendConfig.py Tue Aug 12 10:23:34 2008 +0100
> +++ b/tools/python/xen/xend/XendConfig.py Wed Aug 13 20:43:41 2008 +0900
> @@ -448,7 +448,7 @@ class XendConfig(dict):
> self['platform']['hpet'] = 0
> if 'loader' not in self['platform']:
> # Old configs may have hvmloader set as PV_kernel param
> - if self.has_key('PV_kernel'):
> + if self.has_key('PV_kernel') and self['PV_kernel'] != '':
> self['platform']['loader'] = self['PV_kernel']
> self['PV_kernel'] = ''
> else:
>
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xensource.com
> http://lists.xensource.com/xen-devel
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] Xend: Fix Setting up Platform Parameters
2008-08-13 12:29 ` Keir Fraser
@ 2008-08-13 12:34 ` Keir Fraser
0 siblings, 0 replies; 3+ messages in thread
From: Keir Fraser @ 2008-08-13 12:34 UTC (permalink / raw)
To: Keir Fraser, Yosuke Iwamatsu, xen-devel
Oh sorry, I see why the patch is needed now.
-- Keir
On 13/8/08 13:29, "Keir Fraser" <keir.fraser@eu.citrix.com> wrote:
> So setting self['platform']['loader'] to '' instead of None can break
> booting? How?
>
> -- Keir
>
> On 13/8/08 13:06, "Yosuke Iwamatsu" <y-iwamatsu@ab.jp.nec.com> wrote:
>
>> Make sure that 'PV_kernel' config param is not blank when assigning it
>> to 'loader' param. This fixes a failure of 'xm create' via xen-api.
>>
>> Signed-off-by: Yosuke Iwamatsu <y-iwamatsu@ab.jp.nec.com>
>>
>> diff -r 2c63cf7b042d tools/python/xen/xend/XendConfig.py
>> --- a/tools/python/xen/xend/XendConfig.py Tue Aug 12 10:23:34 2008 +0100
>> +++ b/tools/python/xen/xend/XendConfig.py Wed Aug 13 20:43:41 2008 +0900
>> @@ -448,7 +448,7 @@ class XendConfig(dict):
>> self['platform']['hpet'] = 0
>> if 'loader' not in self['platform']:
>> # Old configs may have hvmloader set as PV_kernel param
>> - if self.has_key('PV_kernel'):
>> + if self.has_key('PV_kernel') and self['PV_kernel'] != '':
>> self['platform']['loader'] = self['PV_kernel']
>> self['PV_kernel'] = ''
>> else:
>>
>> _______________________________________________
>> Xen-devel mailing list
>> Xen-devel@lists.xensource.com
>> http://lists.xensource.com/xen-devel
>
>
>
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xensource.com
> http://lists.xensource.com/xen-devel
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2008-08-13 12:34 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-08-13 12:06 [PATCH] Xend: Fix Setting up Platform Parameters Yosuke Iwamatsu
2008-08-13 12:29 ` Keir Fraser
2008-08-13 12:34 ` Keir Fraser
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.