Re: [Xen-devel] Re: [Qemu-devel] [PATCH 00/11] merge some xen bits into qemu

[Gerd Hoffmann <kraxel@redhat.com>]

Samuel Thibault wrote:
> Gerd Hoffmann, le Mon 18 Aug 2008 14:45:08 +0200, a écrit :
>> Samuel Thibault wrote:
>>> Well, maybe having a version of the patch that does not convert the code
>>> into the qemu identation would help a lot for on-list review.
>> Hmm, dunno how to do that best, git-format-patch seems to lack an
>> equivalent of "diff -b" ...
> 
> In verson 1.5.6.3 at least there is a -b option.

Ok, next respin will have version with that turned on for review.

>>> Also, would it be possible to just have the backend core and
>>> console+framebuffer patches alone?  I don't see why we would need to
>>> change xen_machine_pv.c at all.
>> To stay closer to upstream?
> 
> To limit the amount of changes involved at a time.  If something breaks,
> it's easier to know simply from testing a few changesets whether that's
> because of this or that.

Hmm, that calls more for a patch reordering in the xen patch series to
make it more bisect-friendly (i.e. first put in the new backend drivers,
then update xen_machine_pv.c).  Right now each step single step builds,
but there are a few inbetween which are not fully functional due to old
backends being turned off and new ones not patched in yet ...

>>> That being said, I guess we should wait for a pull in the qemu-xen tree.
>> I'd prefer to not have a patch backlog with tons of unmerged stuff ...
> 
> I doubt you'll be able to produce tons of stuff until that happens.

Even right now the patch queue is uncomfortably long for my taste.

cheers,
  Gerd

-- 
http://kraxel.fedorapeople.org/xenner/