From: Christoph Lameter <cl@linux-foundation.org>
To: Mel Gorman <mel@csn.ul.ie>
Cc: Adam Litke <agl@us.ibm.com>, linux-mm <linux-mm@kvack.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
nacc <nacc@linux.vnet.ibm.com>, apw <apw@shadowen.org>,
agl <agl@linux.vnet.ibm.com>
Subject: Re: [BUG] __GFP_THISNODE is not always honored
Date: Mon, 18 Aug 2008 14:14:24 -0500 [thread overview]
Message-ID: <48A9CA10.80500@linux-foundation.org> (raw)
In-Reply-To: <20080818105918.GD32113@csn.ul.ie>
> That's bad in itself and has wider reaching consequences than hugetlb
> getting its counters wrong. I believe SLUB depends on __GFP_THISNODE
> being obeyed for example. Can you boot the machine in question with
> mminit_loglevel=4 and loglevel=8 set on the command line and send me the
> dmesg please? It should output the zonelists and I might be able to
> figure out what's going wrong. Thanks
Its SLAB depends on it and will corrupt data if the wrong node is returned.
SLAB has BUG_ONs that should trigger if anything like that occurs.
> This will mask the bug for hugetlb but I wonder if this should be a
> VM_BUG_ON(page_to_nid(page) != nid) ?
Right.
WARNING: multiple messages have this Message-ID (diff)
From: Christoph Lameter <cl@linux-foundation.org>
To: Mel Gorman <mel@csn.ul.ie>
Cc: Adam Litke <agl@us.ibm.com>, linux-mm <linux-mm@kvack.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
nacc <nacc@linux.vnet.ibm.com>, apw <apw@shadowen.org>,
agl <agl@linux.vnet.ibm.com>
Subject: Re: [BUG] __GFP_THISNODE is not always honored
Date: Mon, 18 Aug 2008 14:14:24 -0500 [thread overview]
Message-ID: <48A9CA10.80500@linux-foundation.org> (raw)
In-Reply-To: <20080818105918.GD32113@csn.ul.ie>
> That's bad in itself and has wider reaching consequences than hugetlb
> getting its counters wrong. I believe SLUB depends on __GFP_THISNODE
> being obeyed for example. Can you boot the machine in question with
> mminit_loglevel=4 and loglevel=8 set on the command line and send me the
> dmesg please? It should output the zonelists and I might be able to
> figure out what's going wrong. Thanks
Its SLAB depends on it and will corrupt data if the wrong node is returned.
SLAB has BUG_ONs that should trigger if anything like that occurs.
> This will mask the bug for hugetlb but I wonder if this should be a
> VM_BUG_ON(page_to_nid(page) != nid) ?
Right.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2008-08-18 19:16 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-15 22:01 [BUG] __GFP_THISNODE is not always honored Adam Litke
2008-08-15 22:01 ` Adam Litke
2008-08-18 10:59 ` Mel Gorman
2008-08-18 10:59 ` Mel Gorman
2008-08-18 18:16 ` Adam Litke
2008-08-18 19:57 ` Mel Gorman
2008-08-18 19:57 ` Mel Gorman
2008-08-18 19:14 ` Christoph Lameter [this message]
2008-08-18 19:14 ` Christoph Lameter
2008-08-18 19:21 ` Christoph Lameter
2008-08-18 19:21 ` Christoph Lameter
2008-08-18 19:52 ` Mel Gorman
2008-08-18 19:52 ` Mel Gorman
2008-08-20 17:08 ` [BUG] Make setup_zone_migrate_reserve() aware of overlapping nodes Adam Litke
2008-08-20 17:08 ` Adam Litke
2008-08-20 18:11 ` Dave Hansen
2008-08-20 18:11 ` Dave Hansen
2008-08-20 19:55 ` [BUG] [PATCH v2] " Adam Litke
2008-08-20 19:55 ` Adam Litke
2008-08-21 11:33 ` Mel Gorman
2008-08-21 11:33 ` Mel Gorman
2008-08-26 9:29 ` Andy Whitcroft
2008-08-26 9:29 ` Andy Whitcroft
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48A9CA10.80500@linux-foundation.org \
--to=cl@linux-foundation.org \
--cc=agl@linux.vnet.ibm.com \
--cc=agl@us.ibm.com \
--cc=akpm@linux-foundation.org \
--cc=apw@shadowen.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mel@csn.ul.ie \
--cc=nacc@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.