* [PATCH -tip] rcuclassic: fix compilation NG
@ 2008-08-19 4:49 Hiroshi Shimamoto
2008-08-19 9:02 ` Ingo Molnar
0 siblings, 1 reply; 2+ messages in thread
From: Hiroshi Shimamoto @ 2008-08-19 4:49 UTC (permalink / raw)
To: Ingo Molnar, Paul E. McKenney; +Cc: linux-kernel
From: Hiroshi Shimamoto <h-shimamoto@ct.jp.nec.com>
CC kernel/rcuclassic.o
kernel/rcuclassic.c: In function '__rcu_process_callbacks':
kernel/rcuclassic.c:561: error: 'flags' undeclared (first use in this function)
kernel/rcuclassic.c:561: error: (Each undeclared identifier is reported only once
kernel/rcuclassic.c:561: error: for each function it appears in.)
kernel/rcuclassic.c:561: warning: type defaults to 'int' in declaration of '__dummy2'
kernel/rcuclassic.c:561: warning: comparison of distinct pointer types lacks a cast
kernel/rcuclassic.c:561: warning: type defaults to 'int' in declaration of '__dummy2'
kernel/rcuclassic.c:561: warning: comparison of distinct pointer types lacks a cast
kernel/rcuclassic.c:566: warning: type defaults to 'int' in declaration of '__dummy2'
kernel/rcuclassic.c:566: warning: comparison of distinct pointer types lacks a cast
kernel/rcuclassic.c:566: warning: type defaults to 'int' in declaration of '__dummy2'
kernel/rcuclassic.c:566: warning: comparison of distinct pointer types lacks a cast
Declare missing variable flagas.
Signed-off-by: Hiroshi Shimamoto <h-shimamoto@ct.jp.nec.com>
---
kernel/rcuclassic.c | 2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/kernel/rcuclassic.c b/kernel/rcuclassic.c
index c6b6cf5..01e761a 100644
--- a/kernel/rcuclassic.c
+++ b/kernel/rcuclassic.c
@@ -557,6 +557,8 @@ static void __rcu_process_callbacks(struct rcu_ctrlblk *rcp,
local_irq_enable();
if (rcu_batch_after(rdp->batch, rcp->pending)) {
+ unsigned long flags;
+
/* and start it/schedule start if it's a new batch */
spin_lock_irqsave(&rcp->lock, flags);
if (rcu_batch_after(rdp->batch, rcp->pending)) {
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH -tip] rcuclassic: fix compilation NG
2008-08-19 4:49 [PATCH -tip] rcuclassic: fix compilation NG Hiroshi Shimamoto
@ 2008-08-19 9:02 ` Ingo Molnar
0 siblings, 0 replies; 2+ messages in thread
From: Ingo Molnar @ 2008-08-19 9:02 UTC (permalink / raw)
To: Hiroshi Shimamoto; +Cc: Paul E. McKenney, linux-kernel
* Hiroshi Shimamoto <h-shimamoto@ct.jp.nec.com> wrote:
> From: Hiroshi Shimamoto <h-shimamoto@ct.jp.nec.com>
>
> CC kernel/rcuclassic.o
> kernel/rcuclassic.c: In function '__rcu_process_callbacks':
> kernel/rcuclassic.c:561: error: 'flags' undeclared (first use in this function)
> kernel/rcuclassic.c:561: error: (Each undeclared identifier is reported only once
> kernel/rcuclassic.c:561: error: for each function it appears in.)
applied, thanks!
Ingo
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2008-08-19 9:03 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-08-19 4:49 [PATCH -tip] rcuclassic: fix compilation NG Hiroshi Shimamoto
2008-08-19 9:02 ` Ingo Molnar
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.