From: Christoph Lameter <cl@linux-foundation.org>
To: Eduard - Gabriel Munteanu <eduard.munteanu@linux360.ro>
Cc: penberg@cs.helsinki.fi, linux-kernel@vger.kernel.org,
linux-mm@kvack.org, rdunlap@xenotime.net, mpm@selenic.com,
tglx@linutronix.de, rostedt@goodmis.org,
mathieu.desnoyers@polymtl.ca, tzanussi@gmail.com
Subject: Re: [PATCH 3/5] SLUB: Replace __builtin_return_address(0) with _RET_IP_.
Date: Tue, 19 Aug 2008 13:14:01 -0500 [thread overview]
Message-ID: <48AB0D69.4090703@linux-foundation.org> (raw)
In-Reply-To: <1219167807-5407-3-git-send-email-eduard.munteanu@linux360.ro>
Eduard - Gabriel Munteanu wrote:
> void *kmem_cache_alloc(struct kmem_cache *s, gfp_t gfpflags)
> {
> - return slab_alloc(s, gfpflags, -1, __builtin_return_address(0));
> + return slab_alloc(s, gfpflags, -1, (void *) _RET_IP_);
> }
Could you get rid of the casts by changing the type of parameter of slab_alloc()?
WARNING: multiple messages have this Message-ID (diff)
From: Christoph Lameter <cl@linux-foundation.org>
To: Eduard - Gabriel Munteanu <eduard.munteanu@linux360.ro>
Cc: penberg@cs.helsinki.fi, linux-kernel@vger.kernel.org,
linux-mm@kvack.org, rdunlap@xenotime.net, mpm@selenic.com,
tglx@linutronix.de, rostedt@goodmis.org,
mathieu.desnoyers@polymtl.ca, tzanussi@gmail.com
Subject: Re: [PATCH 3/5] SLUB: Replace __builtin_return_address(0) with _RET_IP_.
Date: Tue, 19 Aug 2008 13:14:01 -0500 [thread overview]
Message-ID: <48AB0D69.4090703@linux-foundation.org> (raw)
In-Reply-To: <1219167807-5407-3-git-send-email-eduard.munteanu@linux360.ro>
Eduard - Gabriel Munteanu wrote:
> void *kmem_cache_alloc(struct kmem_cache *s, gfp_t gfpflags)
> {
> - return slab_alloc(s, gfpflags, -1, __builtin_return_address(0));
> + return slab_alloc(s, gfpflags, -1, (void *) _RET_IP_);
> }
Could you get rid of the casts by changing the type of parameter of slab_alloc()?
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2008-08-19 18:15 UTC|newest]
Thread overview: 60+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-19 17:43 [PATCH 1/5] Revert "kmemtrace: fix printk format warnings" Eduard - Gabriel Munteanu
2008-08-19 17:43 ` Eduard - Gabriel Munteanu
2008-08-19 17:43 ` [PATCH 2/5] kmemtrace: Better alternative to " Eduard - Gabriel Munteanu
2008-08-19 17:43 ` Eduard - Gabriel Munteanu
2008-08-19 17:43 ` [PATCH 3/5] SLUB: Replace __builtin_return_address(0) with _RET_IP_ Eduard - Gabriel Munteanu
2008-08-19 17:43 ` Eduard - Gabriel Munteanu
2008-08-19 17:43 ` [PATCH 4/5] kmemtrace: SLUB hooks Eduard - Gabriel Munteanu
2008-08-19 17:43 ` Eduard - Gabriel Munteanu
2008-08-19 17:43 ` [PATCH 5/5] kmemtrace: Fix 2 typos in documentation Eduard - Gabriel Munteanu
2008-08-19 17:43 ` Eduard - Gabriel Munteanu
2008-08-19 19:10 ` Pekka Enberg
2008-08-19 19:10 ` Pekka Enberg
2008-08-19 19:10 ` [PATCH 4/5] kmemtrace: SLUB hooks Pekka Enberg
2008-08-19 19:10 ` Pekka Enberg
2008-08-19 18:14 ` Christoph Lameter [this message]
2008-08-19 18:14 ` [PATCH 3/5] SLUB: Replace __builtin_return_address(0) with _RET_IP_ Christoph Lameter
2008-08-19 18:24 ` Eduard - Gabriel Munteanu
2008-08-19 18:24 ` Eduard - Gabriel Munteanu
2008-08-19 18:56 ` Christoph Lameter
2008-08-19 18:56 ` Christoph Lameter
2008-08-19 18:59 ` Pekka Enberg
2008-08-19 18:59 ` Pekka Enberg
2008-08-19 19:05 ` Eduard - Gabriel Munteanu
2008-08-19 19:05 ` Eduard - Gabriel Munteanu
2008-08-19 19:09 ` Pekka Enberg
2008-08-19 19:09 ` Pekka Enberg
2008-08-19 19:09 ` Pekka Enberg
2008-08-19 19:09 ` Pekka Enberg
2008-08-19 20:17 ` Christoph Lameter
2008-08-19 20:17 ` Christoph Lameter
2008-08-19 20:16 ` Pekka Enberg
2008-08-19 20:16 ` Pekka Enberg
2008-08-19 20:23 ` Christoph Lameter
2008-08-19 20:23 ` Christoph Lameter
2008-08-19 20:47 ` Pekka Enberg
2008-08-19 20:47 ` Pekka Enberg
2008-08-19 18:50 ` Pekka J Enberg
2008-08-19 18:50 ` Pekka J Enberg
2008-08-19 19:24 ` [PATCH 2/5] kmemtrace: Better alternative to "kmemtrace: fix printk format warnings" Pekka Enberg
2008-08-19 19:24 ` Pekka Enberg
2008-08-19 17:51 ` [PATCH 1/5] Revert " Randy.Dunlap
2008-08-19 17:51 ` Randy.Dunlap
2008-08-19 17:54 ` Eduard - Gabriel Munteanu
2008-08-19 17:54 ` Eduard - Gabriel Munteanu
2008-08-19 18:16 ` Mathieu Desnoyers
2008-08-19 18:16 ` Mathieu Desnoyers
2008-08-19 18:32 ` Eduard - Gabriel Munteanu
2008-08-19 18:32 ` Eduard - Gabriel Munteanu
2008-08-19 19:25 ` Pekka Enberg
2008-08-19 19:25 ` Pekka Enberg
2008-08-19 20:23 ` Mathieu Desnoyers
2008-08-19 20:23 ` Mathieu Desnoyers
2008-08-19 18:47 ` Frank Ch. Eigler
2008-08-19 18:47 ` Frank Ch. Eigler
2008-08-19 19:32 ` Randy.Dunlap
2008-08-19 19:32 ` Randy.Dunlap
2008-08-19 21:37 ` Eduard - Gabriel Munteanu
2008-08-19 21:37 ` Eduard - Gabriel Munteanu
2008-08-19 19:27 ` Pekka Enberg
2008-08-19 19:27 ` Pekka Enberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48AB0D69.4090703@linux-foundation.org \
--to=cl@linux-foundation.org \
--cc=eduard.munteanu@linux360.ro \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mathieu.desnoyers@polymtl.ca \
--cc=mpm@selenic.com \
--cc=penberg@cs.helsinki.fi \
--cc=rdunlap@xenotime.net \
--cc=rostedt@goodmis.org \
--cc=tglx@linutronix.de \
--cc=tzanussi@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.