Re: [Qemu-devel] Re: [5055] Handle terminating signals (Gerd Hoffmann)

[Gerd Hoffmann <kraxel@redhat.com>]

  Hi,

>>          } else {
>> +            if (shutdown_requested)
>> +                break;
>>              timeout = 10;

> Could we define the policy that no patch is merged which introduces new
> compiler warnings?

Just double-checked.  I don't get a warning for some strange reason.
Was wondered how a warning bypassed my attention.

You probably see "ret can be used uninitialized ...", right?

> --- a/vl.c
> +++ b/vl.c
> @@ -7624,8 +7624,10 @@ static int main_loop(void)
>                  timeout = 0;
>              }
>          } else {
> -            if (shutdown_requested)
> +            if (shutdown_requested) {
> +                ret = EXCP_INTERRUPT;
>                  break;
> +            }

Fix looks fine to me.

cheers,
  Gerd

-- 
http://kraxel.fedorapeople.org/xenner/