Re: [Qemu-devel] Re: [5055] Handle terminating signals (Gerd Hoffmann)

[Gerd Hoffmann <kraxel@redhat.com>]

Jan Kiszka wrote:
>> Just double-checked.  I don't get a warning for some strange reason.
>> Was wondered how a warning bypassed my attention.
> 
> I like colorgcc for this a lot (either distcc or icecream is said to
> support this as well). :)

emacs does this too, and it even beams the cursor to the line in
question.  Assuming there is a warning in the first place.

>> You probably see "ret can be used uninitialized ...", right?
> 
> Yep. Are you compiling qemu with gcc-3.3 (here: 3.3.3 hammer, x86_64 host)?

compat-gcc-34 package here, --version says:
gcc34 (GCC) 3.4.6 20060404 (Red Hat 3.4.6-9)

> 
>>> --- a/vl.c
>>> +++ b/vl.c
>>> @@ -7624,8 +7624,10 @@ static int main_loop(void)
>>>                  timeout = 0;
>>>              }
>>>          } else {
>>> -            if (shutdown_requested)
>>> +            if (shutdown_requested) {
>>> +                ret = EXCP_INTERRUPT;
>>>                  break;
>>> +            }
>> Fix looks fine to me.
> 
> So we don't need to bother about no_shutdown in this path?

I don't think so.  The no_shutdown makes qemu stop the vm instead of
exiting instantly, probably to allow analyzing the situation in case of
a guest-triggered shutdown.  There is no point in doing so in case the
vm already is in stopped state.

cheers,
  Gerd

-- 
http://kraxel.fedorapeople.org/xenner/