* [PATCH] devcgroup: remove unused variable
@ 2008-08-25 2:22 Li Zefan
[not found] ` <48B2175E.3070407-BthXqXjhjHXQFUHtdCDX3A@public.gmane.org>
2008-08-25 16:43 ` Serge E. Hallyn
0 siblings, 2 replies; 4+ messages in thread
From: Li Zefan @ 2008-08-25 2:22 UTC (permalink / raw)
To: Andrew Morton; +Cc: Serge E. Hallyn, Paul Menage, LKML, Linux Containers
Signed-off-by: Li Zefan <lizf@cn.fujitsu.com>
---
security/device_cgroup.c | 3 +--
1 files changed, 1 insertions(+), 2 deletions(-)
diff --git a/security/device_cgroup.c b/security/device_cgroup.c
index 9c625f6..d5c15a7 100644
--- a/security/device_cgroup.c
+++ b/security/device_cgroup.c
@@ -355,7 +355,7 @@ static int devcgroup_update_access(struct dev_cgroup *devcgroup,
struct dev_cgroup *cur_devcgroup;
const char *b;
char *endp;
- int retval = 0, count;
+ int count;
struct dev_whitelist_item wh;
if (!capable(CAP_SYS_ADMIN))
@@ -432,7 +432,6 @@ static int devcgroup_update_access(struct dev_cgroup *devcgroup,
}
handle:
- retval = 0;
switch (filetype) {
case DEVCG_ALLOW:
if (!parent_has_perm(devcgroup, &wh))
--
1.5.4.rc3
^ permalink raw reply related [flat|nested] 4+ messages in thread[parent not found: <48B2175E.3070407-BthXqXjhjHXQFUHtdCDX3A@public.gmane.org>]
* Re: [PATCH] devcgroup: remove unused variable
[not found] ` <48B2175E.3070407-BthXqXjhjHXQFUHtdCDX3A@public.gmane.org>
@ 2008-08-25 16:43 ` Serge E. Hallyn
0 siblings, 0 replies; 4+ messages in thread
From: Serge E. Hallyn @ 2008-08-25 16:43 UTC (permalink / raw)
To: Li Zefan; +Cc: Linux Containers, Andrew Morton, Paul Menage, LKML
Quoting Li Zefan (lizf-BthXqXjhjHXQFUHtdCDX3A@public.gmane.org):
>
> Signed-off-by: Li Zefan <lizf-BthXqXjhjHXQFUHtdCDX3A@public.gmane.org>
Yup.
Acked-by: Serge Hallyn <serue-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
thanks,
-serge
> ---
> security/device_cgroup.c | 3 +--
> 1 files changed, 1 insertions(+), 2 deletions(-)
>
> diff --git a/security/device_cgroup.c b/security/device_cgroup.c
> index 9c625f6..d5c15a7 100644
> --- a/security/device_cgroup.c
> +++ b/security/device_cgroup.c
> @@ -355,7 +355,7 @@ static int devcgroup_update_access(struct dev_cgroup *devcgroup,
> struct dev_cgroup *cur_devcgroup;
> const char *b;
> char *endp;
> - int retval = 0, count;
> + int count;
> struct dev_whitelist_item wh;
>
> if (!capable(CAP_SYS_ADMIN))
> @@ -432,7 +432,6 @@ static int devcgroup_update_access(struct dev_cgroup *devcgroup,
> }
>
> handle:
> - retval = 0;
> switch (filetype) {
> case DEVCG_ALLOW:
> if (!parent_has_perm(devcgroup, &wh))
> --
> 1.5.4.rc3
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] devcgroup: remove unused variable
2008-08-25 2:22 [PATCH] devcgroup: remove unused variable Li Zefan
[not found] ` <48B2175E.3070407-BthXqXjhjHXQFUHtdCDX3A@public.gmane.org>
@ 2008-08-25 16:43 ` Serge E. Hallyn
1 sibling, 0 replies; 4+ messages in thread
From: Serge E. Hallyn @ 2008-08-25 16:43 UTC (permalink / raw)
To: Li Zefan; +Cc: Andrew Morton, Paul Menage, LKML, Linux Containers
Quoting Li Zefan (lizf@cn.fujitsu.com):
>
> Signed-off-by: Li Zefan <lizf@cn.fujitsu.com>
Yup.
Acked-by: Serge Hallyn <serue@us.ibm.com>
thanks,
-serge
> ---
> security/device_cgroup.c | 3 +--
> 1 files changed, 1 insertions(+), 2 deletions(-)
>
> diff --git a/security/device_cgroup.c b/security/device_cgroup.c
> index 9c625f6..d5c15a7 100644
> --- a/security/device_cgroup.c
> +++ b/security/device_cgroup.c
> @@ -355,7 +355,7 @@ static int devcgroup_update_access(struct dev_cgroup *devcgroup,
> struct dev_cgroup *cur_devcgroup;
> const char *b;
> char *endp;
> - int retval = 0, count;
> + int count;
> struct dev_whitelist_item wh;
>
> if (!capable(CAP_SYS_ADMIN))
> @@ -432,7 +432,6 @@ static int devcgroup_update_access(struct dev_cgroup *devcgroup,
> }
>
> handle:
> - retval = 0;
> switch (filetype) {
> case DEVCG_ALLOW:
> if (!parent_has_perm(devcgroup, &wh))
> --
> 1.5.4.rc3
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH] devcgroup: remove unused variable
@ 2008-08-25 2:22 Li Zefan
0 siblings, 0 replies; 4+ messages in thread
From: Li Zefan @ 2008-08-25 2:22 UTC (permalink / raw)
To: Andrew Morton; +Cc: Paul Menage, Linux Containers, LKML
Signed-off-by: Li Zefan <lizf-BthXqXjhjHXQFUHtdCDX3A@public.gmane.org>
---
security/device_cgroup.c | 3 +--
1 files changed, 1 insertions(+), 2 deletions(-)
diff --git a/security/device_cgroup.c b/security/device_cgroup.c
index 9c625f6..d5c15a7 100644
--- a/security/device_cgroup.c
+++ b/security/device_cgroup.c
@@ -355,7 +355,7 @@ static int devcgroup_update_access(struct dev_cgroup *devcgroup,
struct dev_cgroup *cur_devcgroup;
const char *b;
char *endp;
- int retval = 0, count;
+ int count;
struct dev_whitelist_item wh;
if (!capable(CAP_SYS_ADMIN))
@@ -432,7 +432,6 @@ static int devcgroup_update_access(struct dev_cgroup *devcgroup,
}
handle:
- retval = 0;
switch (filetype) {
case DEVCG_ALLOW:
if (!parent_has_perm(devcgroup, &wh))
--
1.5.4.rc3
^ permalink raw reply related [flat|nested] 4+ messages in thread
end of thread, other threads:[~2008-08-25 16:44 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-08-25 2:22 [PATCH] devcgroup: remove unused variable Li Zefan
[not found] ` <48B2175E.3070407-BthXqXjhjHXQFUHtdCDX3A@public.gmane.org>
2008-08-25 16:43 ` Serge E. Hallyn
2008-08-25 16:43 ` Serge E. Hallyn
-- strict thread matches above, loose matches on Subject: below --
2008-08-25 2:22 Li Zefan
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.