From: "Steven A. Falco" <sfalco@harris.com>
To: Alessandro Zummo <alessandro.zummo@towertech.it>
Cc: rtc-linux@googlegroups.com, will.newton@gmail.com,
linux-kernel@vger.kernel.org
Subject: Re: [rtc-linux] Re: [RFC] Driver for Real Time Clock chip ST M41T65
Date: Tue, 26 Aug 2008 10:39:22 -0400 [thread overview]
Message-ID: <48B4159A.9070907@harris.com> (raw)
In-Reply-To: <20080826161353.6326f6e2@i1501.lan.towertech.it>
Alessandro Zummo wrote:
> On Tue, 26 Aug 2008 15:00:03 +0100
> "Will Newton" <will.newton@gmail.com> wrote:
>
>
>>>> On Mon, Aug 25, 2008 at 6:27 PM, Steven A. Falco <sfalco@harris.com> wrote:
>>>>> I will be using a Real Time Clock chip, ST M41T65, on a new embedded system.
>>>>> The chip is quite similar to the M41T8x family, which already has driver
>>>>> rtc-m41t80.c.
>>>>>
>>>>> Would it be more acceptible to generalize rtc-m41t80.c (perhaps renaming it to
>>>>> rtc-m41txx.c) or would it be better to create a new rtc-m41t6x.c?
>>> Thanks for the feedback. Here is a respin which addresses your comments.
>>>
>>> I'd also like to know if I should submit a new driver or mod the existing
>>> one. If I mod the existing one, should it be renamed, should I update the
>>> Kconfig, existing defconfigs, etc?
>
> Given the small amount of changes, I would use the existing driver without
> renaming it.
>
Sounds good. Please let me know if there are other changes needed to make this
patch acceptable for inclusion into the mainline.
Steve
next prev parent reply other threads:[~2008-08-26 14:43 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-25 17:27 [RFC] Driver for Real Time Clock chip ST M41T65 Steven A. Falco
2008-08-26 8:30 ` Will Newton
2008-08-26 13:55 ` Steven A. Falco
2008-08-26 14:00 ` Will Newton
2008-08-26 14:13 ` [rtc-linux] " Alessandro Zummo
2008-08-26 14:39 ` Steven A. Falco [this message]
2008-08-27 12:35 ` Atsushi Nemoto
2008-08-27 13:32 ` Steven A. Falco
2008-08-27 13:53 ` Atsushi Nemoto
2008-08-27 16:25 ` Maciej W. Rozycki
2008-08-27 17:22 ` Steven A. Falco
2008-08-27 19:27 ` Maciej W. Rozycki
2008-08-27 19:44 ` Alessandro Zummo
2008-08-26 14:42 ` Maciej W. Rozycki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48B4159A.9070907@harris.com \
--to=sfalco@harris.com \
--cc=alessandro.zummo@towertech.it \
--cc=linux-kernel@vger.kernel.org \
--cc=rtc-linux@googlegroups.com \
--cc=will.newton@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.