From: Jeff Garzik <jgarzik@pobox.com>
To: benh@kernel.crashing.org
Cc: netdev <netdev@vger.kernel.org>,
Sebastian Siewior <bigeasy@linutronix.de>,
linuxppc-dev list <linuxppc-dev@ozlabs.org>
Subject: Re: [PATCH] ibm_newemac: Don't call dev_mc_add() before device is registered
Date: Wed, 27 Aug 2008 05:56:28 -0400 [thread overview]
Message-ID: <48B524CC.6020309@pobox.com> (raw)
In-Reply-To: <1219008563.28339.15.camel@pasglop>
Benjamin Herrenschmidt wrote:
> We must not call dev_mc_add() from within our HW configure which happens
> before we initialize and register the netdev. Do it in open() instead.
>
> Thanks to Sebastian Siewior for tracking it down.
>
> Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
> ---
>
> This fixes an uninitialized spinlock warning (and possibly more).
>
> Please apply.
applied
WARNING: multiple messages have this Message-ID (diff)
From: Jeff Garzik <jgarzik@pobox.com>
To: benh@kernel.crashing.org
Cc: netdev <netdev@vger.kernel.org>,
linuxppc-dev list <linuxppc-dev@ozlabs.org>,
Sebastian Siewior <bigeasy@linutronix.de>
Subject: Re: [PATCH] ibm_newemac: Don't call dev_mc_add() before device is registered
Date: Wed, 27 Aug 2008 05:56:28 -0400 [thread overview]
Message-ID: <48B524CC.6020309@pobox.com> (raw)
In-Reply-To: <1219008563.28339.15.camel@pasglop>
Benjamin Herrenschmidt wrote:
> We must not call dev_mc_add() from within our HW configure which happens
> before we initialize and register the netdev. Do it in open() instead.
>
> Thanks to Sebastian Siewior for tracking it down.
>
> Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
> ---
>
> This fixes an uninitialized spinlock warning (and possibly more).
>
> Please apply.
applied
next prev parent reply other threads:[~2008-08-27 9:56 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-17 21:29 [PATCH] ibm_newemac: Don't call dev_mc_add() before device is registered Benjamin Herrenschmidt
2008-08-17 21:29 ` Benjamin Herrenschmidt
2008-08-27 9:56 ` Jeff Garzik [this message]
2008-08-27 9:56 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48B524CC.6020309@pobox.com \
--to=jgarzik@pobox.com \
--cc=benh@kernel.crashing.org \
--cc=bigeasy@linutronix.de \
--cc=linuxppc-dev@ozlabs.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.