From: Gerd Hoffmann <kraxel@redhat.com>
To: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [patch] add byteordered types
Date: Wed, 27 Aug 2008 16:35:49 +0200 [thread overview]
Message-ID: <48B56645.60206@redhat.com> (raw)
In-Reply-To: <200808271456.57273.paul@codesourcery.com>
Paul Brook wrote:
> On Wednesday 27 August 2008, Gerd Hoffmann wrote:
>> +static inline le16 write_le16(uint16_t cpu) \
>
> This is IMHO a bad name for this function. It doesn't write anything.
I'm not that happy the name too and certainly open for better
suggestions I could use instead of read/write.
The alternatives I can think of are not very nice either:
(1) get/set -- same problem as read/write.
(2) make_foo() instead of write_foo() -- "make" is too generic IMHO.
(3) create_foo() instead of write_foo() -- no nice symmetric
replacement for read_foo().
better ideas anyone?
cheers,
Gerd
next prev parent reply other threads:[~2008-08-27 14:36 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-27 11:44 [Qemu-devel] [patch] add byteordered types Gerd Hoffmann
2008-08-27 12:20 ` Paul Brook
2008-08-27 13:04 ` Gerd Hoffmann
2008-08-27 13:24 ` Gerd Hoffmann
2008-08-27 13:55 ` Paul Brook
2008-08-27 14:12 ` M. Warner Losh
2008-08-27 13:56 ` Paul Brook
2008-08-27 14:35 ` Gerd Hoffmann [this message]
2008-08-27 14:47 ` M. Warner Losh
2008-08-27 15:06 ` Gerd Hoffmann
2008-08-27 15:49 ` Anthony Liguori
2008-08-27 16:20 ` Gerd Hoffmann
2008-08-27 17:57 ` Anthony Liguori
2008-08-28 8:36 ` Gerd Hoffmann
2008-08-27 18:19 ` Jamie Lokier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48B56645.60206@redhat.com \
--to=kraxel@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.